[DrupalCon] Automatic Updates alpha test result

It would good if someone could test the instructions https://www.drupal.org/project/automatic_updates/issues/3365152 🌱 3.0.0 Alpha Testing Instructions Active
but updating directly from 10.0.0 to 10.1.0-alpha1, or whatever the current version of 10.1.x is. To see if we get the same error.

I thought maybe BigPipeResponseAttachmentsProcessor changed in 10.1 but I couldn't find anything. But it is likely there might related change that affects this.

another person got this problem with Big Pipe in 🐛 [DrupalCon] Automatic Updates alpha test result Active

My guess would be there is some sort of change in 10.1 that doesn't work our batch update system.

The wording problem relates to 📌 Status check error and warning summary messages do not make sense on the updater forms Fixed

I tried updating my site from 10.0.0 to 10.1.0-rc1 and I also get the warning message on ready to update page see and when I hit continue it shows me progress bar of applying updates and then update.php automatically runs and when I go back to site it is updated to 10.1.0-rc1.

I wasn't even able to complete my update,
1.

2.

3.When i try to check the status report.

Message ArgumentCountError: Too few arguments to function Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor::__construct(), 8 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 263 and exactly 9 expected in Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor->__construct() (line 55 of /var/www/html/web/core/modules/big_pipe/src/Render/BigPipeResponseAttachmentsProcessor.php).

🤯 Wow.

Fortunately I'm a BigPipe maintainer! 🤓

Unfortunately I'm puzzled. 😅

BigPipe is installed by default. We all run it when developing Automatic Updates. NOPE, build tests use minimal!

We should be running build tests with standard.

#4:

My guess would be there is some sort of change in 10.1 that doesn't work our batch update system.

Nothing BigPipe-related changed in 10.1. But what did change significantly is how assets are generated and served.

My bet would be that's what's causing this. And I bet we're hitting some sort of race condition with enabling maintenance mode that makes assets generation fail (while maintenance mode is on).

#7: can you please check the watchdog table, where type = 'php'? 🙏 Because without a precise error message, we're nowhere.

Actually, no, the root cause here is simpler: 🐛 Stampedes and cold cache performance issues with css/js aggregation Fixed landed a change in August 2022, which indeed added a new required argument to \Drupal\big_pipe\Render\BigPipeResponseAttachmentsProcessor::__construct().

The fact that this error message appears then leaves only one possible conclusion: the dependency injection container is not being rebuilt immediately after copying the files from "stage" to "active": at least one request is getting through to "active" before the container is rebuilt, which is causing this error message. 🫣

Assigning to myself to make follow-up issues. Thanks @kunal.sachdev and @omkar.podey for testing and thanks @Wim Leers for the investigation

Created
📌 In Core build tests have core module change a service class constructor Active
📌 Change build tests to install Standard profile Needs work

Still needs follow-up for messaging issues(or to find existing issues which I think there is)

@UpTil4Music thanks for testing, credited you on those issues