- Issue created by @tedbow
- First commit to issue fork.
- last update
over 1 year ago 794 pass, 1 fail - @phenaproxima opened merge request.
- last update
over 1 year ago 794 pass, 2 fail - last update
over 1 year ago 800 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 7:45pm 12 June 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 7:50pm 12 June 2023 - last update
over 1 year ago 800 pass - last update
over 1 year ago 800 pass - Status changed to RTBC
over 1 year ago 8:20pm 12 June 2023 - last update
over 1 year ago 800 pass - Status changed to Needs work
over 1 year ago 8:56pm 12 June 2023 -
phenaproxima β
committed b9c9f19b on 3.0.x
Issue #3366267 by phenaproxima, tedbow: Change build tests to install...
-
phenaproxima β
committed b9c9f19b on 3.0.x
- Status changed to Fixed
over 1 year ago 8:56pm 12 June 2023 - Issue was unassigned.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Self-crediting because this implemented the solution I suggested in #3365463-8: [DrupalCon] Automatic Updates alpha test result β . π
- Status changed to Needs work
over 1 year ago 9:27am 13 June 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Actuallyβ¦
// Uninstall Automated Cron, which is not supported by Automatic Updates. // Also uninstall Big Pipe, since it may cause page elements to be rendered // in the background and replaced with JavaScript, which isn't supported in // build tests. // @see \Drupal\automatic_updates\Validator\AutomatedCronDisabledValidator $page = $this->getMink()->getSession()->getPage(); $this->visit('/admin/modules/uninstall'); $page->checkField("uninstall[automated_cron]"); $page->checkField('uninstall[big_pipe]'); $page->pressButton('Uninstall'); $page->pressButton('Uninstall');
β¦ this means that the problem that #3365463 reported still would not be caught π
Is that what this bit in the issue summary meant?
[β¦] We might not have caught this anyways because The actual code would not have changed but we can improve our test coverage by installing standard for our build tests
It'd have been good to call that out explicitly on this issue then, because it's currently kinda misleading, since BEFORE that, the issue summary says
Ran into a problem with Big Pipe in testing π [DrupalCon] Automatic Updates alpha test result Needs work . [β¦]
P.S.: Also why press that "Uninstall" button twice? π€
- πΊπΈUnited States phenaproxima Massachusetts
β¦ this means that the problem that #3365463 reported still would not be caught
Yeah. We're gonna need a separate issue for that, with a dedicated functional JS test in some way.
Also why press that "Uninstall" button twice?
Once on the main uninstall form, and again to confirm the action (there's a confirm form for uninstalls). I guess I shoulda put a comment there.