BrokenPostRequestException incorrectly typehints size as string

Issue created by @kim.pepper
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Not currently mergeable.
@kimpepper opened merge request.
Status changed to Needs review over 1 year ago7:14am 5 June 2023
Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Comment over 1 year ago →
System Message
kim.pepper → closed merge request !4103
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,415 pass
@kimpepper opened merge request.
Status changed to RTBC over 1 year ago12:59pm 5 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Change looks good.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,417 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,436 pass
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Is it ever a float? Surely byte counts are always integer values?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,437 pass
Status changed to Needs work over 1 year ago7:09am 10 June 2023
Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Is it ever a float? Surely byte counts are always integer values?

Hmm. Yeah worth a look rather than just copying over existing functionality.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,414 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,437 pass
Status changed to Needs review over 1 year ago10:21pm 11 June 2023
Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Status changed to RTBC over 1 year ago1:30am 13 June 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Float has been removed. Think this could use a change record? Probably not but wanted to ask.
Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Think this could use a change record?

Don't think so. It's a bug.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,445 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,473 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,499 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
50:19
46:25
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,508 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,553 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,553 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,559 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,565 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,571 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,799 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,804 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,811 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,814 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,826 pass
Comment over 1 year ago →
System Message

longwave → committed e2aeff00 on 11.x
Issue #3364774 by kim.pepper: BrokenPostRequestException incorrectly...
Status changed to Fixed over 1 year ago1:45pm 22 July 2023
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Committed and pushed e2aeff0026 to 11.x. Thanks!

Decided not to backport as this is a very minor behaviour change and there is a small chance someone was relying on the string type somehow.
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

BrokenPostRequestException incorrectly typehints size as string

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities