- Issue created by @wim leers
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:51pm 2 June 2023 - last update
over 1 year ago 3 pass - last update
over 1 year ago 3 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
For something more interesting, see
$ vendor/bin/drush config:inspect --filter-keys=editor.editor.basic_html --detail --list-constraints's output after a fresh install (which made me refine the output for Drush because it was impossible to distinguish some things):$ vendor/bin/drush config:inspect --filter-keys=editor.editor.basic_html --detail --list-constraints Legend for Data: ✅❓ → Correct primitive type, detailed validation impossible. ✅✅ → Correct primitive type, passed all validation constraints. --------------------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------- Key Status Validatable Data Validation constraints --------------------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------- editor.editor.basic_html Correct 68% ✅❓ editor.editor.basic_html: Correct NOT ✅❓ editor.editor.basic_html:_core Correct NOT ✅❓ editor.editor.basic_html:_core.default_config_hash Correct NOT ✅❓ editor.editor.basic_html:dependencies Correct Validatable ✅✅ ValidKeys: '<infer>' editor.editor.basic_html:dependencies.config Correct NOT ✅❓ editor.editor.basic_html:dependencies.config.0 Correct Validatable ✅✅ NotBlank: { } ConfigExists: { } ↣ PrimitiveType: { } editor.editor.basic_html:dependencies.module Correct NOT ✅❓ editor.editor.basic_html:dependencies.module.0 Correct Validatable ✅✅ NotBlank: { } ExtensionName: { } ExtensionExists: module ↣ PrimitiveType: { } editor.editor.basic_html:editor Correct Validatable ✅✅ PluginExists: manager: plugin.manager.editor interface: Drupal\editor\Plugin\EditorPluginInterface ↣ PrimitiveType: { } editor.editor.basic_html:format Correct NOT ✅❓ editor.editor.basic_html:image_upload Correct NOT ✅❓ editor.editor.basic_html:image_upload.directory Correct NOT ✅❓ editor.editor.basic_html:image_upload.max_dimensions Correct NOT ✅❓ editor.editor.basic_html:image_upload.max_dimensions.height Correct NOT ✅❓ editor.editor.basic_html:image_upload.max_dimensions.width Correct NOT ✅❓ editor.editor.basic_html:image_upload.max_size Correct NOT ✅❓ editor.editor.basic_html:image_upload.scheme Correct NOT ✅❓ editor.editor.basic_html:image_upload.status Correct Validatable ✅✅ ↣ PrimitiveType: { } editor.editor.basic_html:langcode Correct NOT ✅❓ editor.editor.basic_html:settings Correct Validatable ✅✅ CKEditor5EnabledConfigurablePlugins: { } editor.editor.basic_html:settings.plugins Correct NOT ✅❓ editor.editor.basic_html:settings.plugins.ckeditor5_heading Correct NOT ✅❓ editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ NotBlank: enabled_headings message: 'Enable at least one heading, otherwise disable the Heading plugin.' editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.0 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.1 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.2 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.3 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.4 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_heading. Correct Validatable ✅✅ Choice: enabled_headings.5 callback: '\Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading::validChoices' ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_list Correct NOT ✅❓ editor.editor.basic_html:settings.plugins.ckeditor5_list.rev Correct Validatable ✅✅ NotNull: { } ersed ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_list.sta Correct Validatable ✅✅ NotNull: { } rtIndex ↣ PrimitiveType: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct NOT ✅❓ iting editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct NOT ✅❓ iting.allowed_tags editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.0 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.1 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.10 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.11 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.12 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.2 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.3 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.4 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.5 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.6 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.7 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.8 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.ckeditor5_sourceEd Correct Validatable ✅✅ SourceEditingRedundantTags: { } iting.allowed_tags.9 SourceEditingPreventSelfXssConstraint: { } ↣ PrimitiveType: { } ↣ CKEditor5Element: { } editor.editor.basic_html:settings.plugins.media_media Correct NOT ✅❓ editor.editor.basic_html:settings.plugins.media_media.allow_ Correct Validatable ✅✅ NotNull: { } view_mode_override ↣ PrimitiveType: { } editor.editor.basic_html:settings.toolbar Correct NOT ✅❓ editor.editor.basic_html:settings.toolbar.items Correct NOT ✅❓ editor.editor.basic_html:settings.toolbar.items.0 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.1 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.10 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.11 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.12 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.13 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.14 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.2 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.3 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.4 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.5 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.6 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.7 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.8 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:settings.toolbar.items.9 Correct Validatable ✅✅ CKEditor5ToolbarItemConditionsMet: { } ↣ PrimitiveType: { } ↣ CKEditor5ToolbarItem: { } editor.editor.basic_html:status Correct Validatable ✅✅ ↣ PrimitiveType: { } editor.editor.basic_html:uuid Correct Validatable ✅✅ Uuid: { } ↣ PrimitiveType: { } --------------------------------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------- - Status changed to Needs work
over 1 year ago 1:43pm 2 June 2023 - 🇳🇱Netherlands ronaldtebrake
That drush output, how neat 😍
---
private static function getPrintableConstraints(ConfigSchemaValidatability $validatability, string $property_path): array { + $all_constraints = $validatability->getConstraints($property_path); + $local_constraints = array_map( + fn (string $constraint_name, $constraints_options) => trim(Yaml::encode([$constraint_name => $constraints_options])), + array_keys($all_constraints['local']), + array_values($all_constraints['local']) + ); + $inherited_constraints = array_map( + fn (string $constraint_name, $constraints_options) => "↣ " . trim(Yaml::encode([$constraint_name => $constraints_options])), + array_keys($all_constraints['inherited']), + array_values($all_constraints['inherited']) + ); + + return array_merge($local_constraints, $inherited_constraints); return array_map( fn (Constraint $constraint) => get_class($constraint), $validatability->getConstraints($property_path)Think we can remove the
return array_mapat the end. - Status changed to Needs review
over 1 year ago 2:01pm 2 June 2023 - last update
over 1 year ago 3 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@Gábor Hojtsy gave me commit access at DrupalCon! 🤓😄
Let's ship this!
- Status changed to RTBC
over 1 year ago 7:45pm 7 June 2023 -
Wim Leers →
committed e4402156 on 2.1.x
Issue #3364412 by Wim Leers, ronaldtebrake, Gábor Hojtsy: Improve...
-
Wim Leers →
committed e4402156 on 2.1.x
- Status changed to Fixed
over 1 year ago 7:55pm 7 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.
