- Issue created by @mukeysh
- Status changed to Needs work
over 1 year ago 7:27am 31 May 2023 - Status changed to Needs review
over 1 year ago 7:59am 31 May 2023 - 🇮🇳India bunty oberoi
Hi Mukeysh,
Verified and tested Patch Comment #3 on Drupal Version 10.1.0-dev & PHP Version 8.1.16
Testing Steps:-
1). Install Drupal 10.1.0 version.
2). git clone --branch '5.0.x' https://git.drupalcode.org/project/radix.git
Followed the above steps given
3). Applied Patch #3 /projects/drupal/themes/contrib/radix/3363752-radix-subtheme-npm-compilation-issue.patch
4). Checked the changes difference using git diff
5). Installed theme and set it as default.
6). Run Commandnpm run watch
Testing result:
Patch Comment #3 fixed the issue
Here I have attached the before and after apply patch screenshots.
Moved the issue to RTBC ++ - 🇺🇸United States morbus iff
I think just
@import '~bootstrap/scss/variables-dark';
would be the better approach, right?
- 🇮🇳India shyam_bhatt Gujarat
Updated the
@import '~bootstrap/scss/variables-dark';
instead of@import "~bootstrap/scss/_variables-dark.scss";
on the same file for better code practice and creating a new patch.I have checked the patch and added the after and before screenshots.
Please refer #5 🐛 Radix sub theme npm compilation issue Fixed steps for the testing. Needs review
- 🇮🇳India shyam_bhatt Gujarat
After creating SUB_THEME, Go to theme path
"cd /path/to/SUBTHEME_NAME"
and then runnpm install
.When running
npm run watch
the following error message appears which stops the SCSS to CSS compilation.
After updating the@import '~bootstrap/scss/variables-dark';
instead of@import "~bootstrap/scss/_variables-dark.scss";
found some errors as below:To fix this I have updated the new patch. Please check the patch and the after image for the same.
Needs review.
- Status changed to Fixed
over 1 year ago 9:31am 15 June 2023 Thanks everyone for the work here, the correct approach would be to do
@import "~bootstrap/scss/variables-dark";
Fixed on the dev version for now, will release a new tag shortly, great work everyone
-
doxigo →
committed fcd6588b on 5.0.x authored by
Shyam_Bhatt →
Issue #3363752 by Shyam_Bhatt, Mukeysh, bunty oberoi, Morbus Iff, doxigo...
-
doxigo →
committed fcd6588b on 5.0.x authored by
Shyam_Bhatt →
Automatically closed - issue fixed for 2 weeks with no activity.