Fix the issues reported by phpcs

Created on 29 May 2023, over 1 year ago
Updated 24 May 2024, 6 months ago

Problem/Motivation

FILE: ...bution/drupal10/web/modules/contrib/pseudo_link/pseudo_link.links.menu.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...l/contribution/drupal10/web/modules/contrib/pseudo_link/pseudo_link.module
--------------------------------------------------------------------------------
FOUND 252 ERRORS AND 10 WARNINGS AFFECTING 113 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
3 | WARNING | [x] Unused use statement
4 | WARNING | [x] Unused use statement
5 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
6 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
14 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
17 | ERROR | [x] Expected 1 space after "="; 2 found
19 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
19 | WARNING | [ ] Unused variable $key.
20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
20 | ERROR | [x] Expected 1 space after "="; 2 found
21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
21 | ERROR | [x] Expected 1 space after "="; 2 found
23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
23 | ERROR | [x] Expected 1 space after IF keyword; 0 found
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
24 | WARNING | [ ] Unused variable $bkey.
25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
27 | ERROR | [x] Concat operator must be surrounded by a single space
27 | ERROR | [x] Concat operator must be surrounded by a single space
28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
28 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
28 | ERROR | [x] Concat operator must be surrounded by a single space
29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
29 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
29 | ERROR | [x] Expected 1 space after IF keyword; 0 found
30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
30 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 5
31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
31 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
32 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
33 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
33 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
34 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE"
| | but found "False"
35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
39 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
41 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
49 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
53 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
53 | ERROR | [x] Expected 1 space after IF keyword; 0 found
54 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
56 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
57 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
57 | ERROR | [x] Concat operator must be surrounded by a single space
57 | ERROR | [x] Concat operator must be surrounded by a single space
58 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
58 | ERROR | [x] Concat operator must be surrounded by a single space
59 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
59 | ERROR | [x] Expected 1 space after IF keyword; 0 found
60 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
60 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
62 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
62 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
62 | ERROR | [x] Concat operator must be surrounded by a single space
63 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
63 | ERROR | [x] Concat operator must be surrounded by a single space
64 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
64 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
64 | ERROR | [x] Concat operator must be surrounded by a single space
65 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
65 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
65 | ERROR | [x] Concat operator must be surrounded by a single space
66 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
66 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
66 | ERROR | [x] Concat operator must be surrounded by a single space
67 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
67 | WARNING | [ ] Unused variable $entity_url.
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
69 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
69 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
69 | ERROR | [x] Expected 1 space after "="; 2 found
69 | ERROR | [x] Expected 1 space before "?"; 0 found
69 | ERROR | [x] Expected 1 space after "?"; 0 found
69 | ERROR | [x] Expected 1 space before ":"; 0 found
69 | ERROR | [x] Expected 1 space after ":"; 0 found
71 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
71 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
71 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
72 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
72 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
73 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
73 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
75 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
75 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
76 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
76 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
78 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
78 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
78 | ERROR | [x] Expected 1 space after IF keyword; 0 found
79 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
79 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 5
80 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
80 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
80 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: '_blank'
81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
82 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
83 | ERROR | [x] Expected 1 space after IF keyword; 0 found
84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
84 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 5
84 | ERROR | [x] Short array syntax must be used to define arrays
85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
85 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
87 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
88 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
89 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
93 | ERROR | [x] Doc comment short description must end with a full stop
94 | ERROR | [x] There must be exactly one blank line before the tags in a
| | doc comment
94 | ERROR | [ ] Return type missing for @return tag in function comment
94 | ERROR | [ ] Description for the @return value is missing
97 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
97 | ERROR | [x] Short array syntax must be used to define arrays
98 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
98 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
99 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
99 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
100 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
100 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
101 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
101 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
102 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
102 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
103 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
103 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
104 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
104 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
105 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
105 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
106 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
106 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
107 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
107 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
108 | ERROR | [x] Array indentation error, expected 3 spaces but found 2
109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
111 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
115 | ERROR | [x] Doc comment short description must end with a full stop
116 | ERROR | [x] There must be exactly one blank line before the tags in a
| | doc comment
116 | ERROR | [ ] Return type missing for @return tag in function comment
116 | ERROR | [ ] Description for the @return value is missing
119 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
120 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
120 | WARNING | [ ] Unused variable $entity_types.
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
122 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
124 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
124 | ERROR | [x] Short array syntax must be used to define arrays
125 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
125 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
126 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
126 | ERROR | [x] Expected 1 space after IF keyword; 0 found
127 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
127 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
127 | ERROR | [x] Short array syntax must be used to define arrays
128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
128 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces,
| | found 4
128 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
129 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces,
| | found 4
129 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
132 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
132 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
133 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
133 | ERROR | [x] Short array syntax must be used to define arrays
134 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
134 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
134 | ERROR | [x] Expected 1 space after IF keyword; 0 found
135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
135 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
136 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 5
136 | ERROR | [x] Short array syntax must be used to define arrays
137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
137 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
137 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
138 | ERROR | [x] Line indented incorrectly; expected at least 10 spaces,
| | found 6
138 | ERROR | [x] Array indentation error, expected 7 spaces but found 6
139 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
141 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
141 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 5
142 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
142 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
143 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
143 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
144 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
144 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
145 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
146 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
148 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
154 | ERROR | [ ] pseudo_link_uninstall() is an installation hook and must
| | be declared in an install file
155 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
155 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
156 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
157 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
158 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
158 | ERROR | [x] Expected 1 space after IF keyword; 0 found
159 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
159 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
160 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
161 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 252 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...n/drupal10/web/modules/contrib/pseudo_link/src/Form/EntitySettingsForm.php
--------------------------------------------------------------------------------
FOUND 107 ERRORS AND 25 WARNINGS AFFECTING 78 LINES
--------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
17 | ERROR | [x] Expected 1 blank line before function; 0 found
34 | ERROR | [x] Short array syntax must be used to define arrays
35 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'vertical_tabs'
38 | ERROR | [x] Short array syntax must be used to define arrays
43 | ERROR | [x] Short array syntax must be used to define arrays
46 | ERROR | [x] Object operator not indented correctly; expected 10 spaces
| | but found 8
46 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
47 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'information'
54 | ERROR | [x] Concat operator must be surrounded by a single space
54 | ERROR | [x] Concat operator must be surrounded by a single space
56 | ERROR | [x] Expected 1 space after IF keyword; 0 found
60 | ERROR | [x] Concat operator must be surrounded by a single space
60 | ERROR | [x] Short array syntax must be used to define arrays
64 | ERROR | [x] Short array syntax must be used to define arrays
67 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
67 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
67 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
68 | ERROR | [x] Concat operator must be surrounded by a single space
71 | ERROR | [x] Concat operator must be surrounded by a single space
71 | ERROR | [x] Short array syntax must be used to define arrays
74 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
75 | ERROR | [x] Concat operator must be surrounded by a single space
75 | ERROR | [x] Expected 1 space before "??"; 0 found
75 | ERROR | [x] Expected 1 space after "??"; 0 found
76 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
76 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
76 | ERROR | [x] Concat operator must be surrounded by a single space
76 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
79 | ERROR | [x] Concat operator must be surrounded by a single space
79 | ERROR | [x] Short array syntax must be used to define arrays
82 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
82 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
83 | ERROR | [x] Concat operator must be surrounded by a single space
83 | ERROR | [x] Expected 1 space before "??"; 0 found
83 | ERROR | [x] Expected 1 space after "??"; 0 found
84 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
84 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
84 | ERROR | [x] Concat operator must be surrounded by a single space
84 | ERROR | [x] Concat operator must be surrounded by a single space
85 | ERROR | [x] Short array syntax must be used to define arrays
86 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Concat operator must be surrounded by a single space
87 | ERROR | [x] Concat operator must be surrounded by a single space
87 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
88 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
92 | ERROR | [x] Concat operator must be surrounded by a single space
92 | ERROR | [x] Short array syntax must be used to define arrays
95 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
95 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
96 | ERROR | [x] Concat operator must be surrounded by a single space
96 | ERROR | [x] Expected 1 space before "??"; 0 found
96 | ERROR | [x] Expected 1 space after "??"; 0 found
97 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
97 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
97 | ERROR | [x] Concat operator must be surrounded by a single space
97 | ERROR | [x] Concat operator must be surrounded by a single space
98 | ERROR | [x] Short array syntax must be used to define arrays
99 | ERROR | [x] Short array syntax must be used to define arrays
100 | ERROR | [x] Concat operator must be surrounded by a single space
100 | ERROR | [x] Concat operator must be surrounded by a single space
100 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
101 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
105 | ERROR | [x] Concat operator must be surrounded by a single space
105 | ERROR | [x] Short array syntax must be used to define arrays
108 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
108 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
109 | ERROR | [x] Concat operator must be surrounded by a single space
109 | ERROR | [x] Expected 1 space before "??"; 0 found
109 | ERROR | [x] Expected 1 space after "??"; 0 found
110 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
110 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
110 | ERROR | [x] Concat operator must be surrounded by a single space
111 | ERROR | [x] Short array syntax must be used to define arrays
112 | ERROR | [x] Short array syntax must be used to define arrays
113 | ERROR | [x] Concat operator must be surrounded by a single space
113 | ERROR | [x] Concat operator must be surrounded by a single space
113 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
114 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
118 | ERROR | [x] Concat operator must be surrounded by a single space
118 | ERROR | [x] Short array syntax must be used to define arrays
121 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
121 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
122 | ERROR | [x] Concat operator must be surrounded by a single space
122 | ERROR | [x] Expected 1 space before "??"; 0 found
122 | ERROR | [x] Expected 1 space after "??"; 0 found
123 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
123 | ERROR | [ ] Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
123 | ERROR | [x] Concat operator must be surrounded by a single space
124 | ERROR | [x] Short array syntax must be used to define arrays
125 | ERROR | [x] Short array syntax must be used to define arrays
126 | ERROR | [x] Concat operator must be surrounded by a single space
126 | ERROR | [x] Concat operator must be surrounded by a single space
126 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
127 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
131 | ERROR | [x] Concat operator must be surrounded by a single space
131 | ERROR | [x] Short array syntax must be used to define arrays
134 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
134 | ERROR | [x] Object operator not indented correctly; expected 12 spaces
| | but found 10
135 | ERROR | [x] Concat operator must be surrounded by a single space
135 | ERROR | [x] Expected 1 space before "??"; 0 found
135 | ERROR | [x] Expected 1 space after "??"; 0 found
137 | ERROR | [x] Short array syntax must be used to define arrays
138 | ERROR | [x] Short array syntax must be used to define arrays
139 | ERROR | [x] Concat operator must be surrounded by a single space
139 | ERROR | [x] Concat operator must be surrounded by a single space
139 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
140 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
144 | ERROR | [x] Concat operator must be surrounded by a single space
144 | ERROR | [x] Short array syntax must be used to define arrays
146 | ERROR | [x] Expected 1 space after "=>"; 0 found
146 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
162 | WARNING | [ ] Unused variable $key.
165 | ERROR | [x] Expected 1 space after IF keyword; 0 found
166 | WARNING | [ ] Unused variable $bkey.
167 | ERROR | [x] Concat operator must be surrounded by a single space
167 | ERROR | [x] Concat operator must be surrounded by a single space
169 | ERROR | [x] Concat operator must be surrounded by a single space
170 | ERROR | [x] Expected 1 space after IF keyword; 0 found
174 | ERROR | [x] Concat operator must be surrounded by a single space
175 | ERROR | [x] Expected 1 space after IF keyword; 0 found
179 | ERROR | [x] Concat operator must be surrounded by a single space
180 | ERROR | [x] Expected 1 space after IF keyword; 0 found
184 | ERROR | [x] Concat operator must be surrounded by a single space
185 | ERROR | [x] Expected 1 space after IF keyword; 0 found
189 | ERROR | [x] Concat operator must be surrounded by a single space
190 | ERROR | [x] Expected 1 space after IF keyword; 0 found
194 | ERROR | [x] Concat operator must be surrounded by a single space
195 | ERROR | [x] Expected 1 space after IF keyword; 0 found
203 | ERROR | [x] Expected 1 blank line after function; 0 found
204 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 118 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 688ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig pseudo_link/

Remaining tasks

Patch review

šŸ“Œ Task
Status

Needs work

Version

1.2

Component

Code

Created by

šŸ‡®šŸ‡³India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
    + * Get entity bundles on the system.
    + *
    + * @return array
    + *   An array of entity bundles.

    The verb used in the description must be declined in the third person singular.

               '#title' => $this
    -          ->t('Enable Pseudo Link'),
    -          '#default_value' => $config->get($entity_bundle.'_enable_link')??'0',
    -          '#description' => $this->t('Enable pseudo link for '.$label)
    -        );
    +            ->t('Enable Pseudo Link'),
    

    ->t( and $this must be on the same line.

  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India urvashi_vora Madhya Pradesh, India
  • Hi, patch #3 applied cleanly, but still found few errors after patch.

  • Status changed to Needs work 6 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi urvashi_vora,

    As stated by @bindu r, errors were found after applying the patch.

    I applied the patch, it applied smoothly.

    However, also encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

    āžœ  pseudo_link git:(main) āœ— curl https://www.drupal.org/files/issues/2023-05-30/coding-standard-fixes-3.patch |
    pipe> patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 21178  100 21178    0     0   118k      0 --:--:-- --:--:-- --:--:--  119k
    patching file pseudo_link.links.menu.yml
    patching file pseudo_link.module
    patching file src/Form/EntitySettingsForm.php
    āžœ  pseudo_link git:(main) āœ— ..
    āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pseudo_link
    
    FILE: /Users/interns/Demo-site/drupal-orgissue/web/modules/contrib/pseudo_link/pseudo_link.info.yml
    -------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------
     1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
     1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
     1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
    -------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-orgissue/web/modules/contrib/pseudo_link/pseudo_link.module
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AFFECTING 3 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
       9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\Display\EntityViewDisplayInterface.
      98 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "excluded_entity_types" but expected "pseudo_link_excluded_entity_types"
     157 | ERROR | [ ] pseudo_link_uninstall() is an installation hook and must be declared in an install file
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 166ms; Memory: 10MB
    
    āžœ  contrib git:(main) āœ—

    Thank you.

Production build 0.71.5 2024