Drupal Displace outputs invalid value for --drupal-displace-offset-right when opening top dialog

I wonder if this is more a bug with either cd_tools or something with the off-canvas. I'm seeing the data-offset-right attribute on the top dialog which is causing this.

Raising to major, as this also makes the now stable Workspaces impossible to demonstrate with Umami as I just reproduced when trying to screenshot it. When I undid the bogus --drupal-displace-offset-right value, it looked fine with Umami.

→

I never like the auto compute of offset, the issue is that an empty data-offset-right/left is added when the offcanvas is created. Whether it's on the side or on top of the page. Making sure only the relevant attribute is added based on the position solves the issue.

I tried this with both Umami and Workspaces and Umami and Settings tray and they both worked fine. The code looks like the correct solution but I am not an expert in this. Attached videos of how it works after the fix.

Did a more extensive code context review and this looks like indeed the right place and way to fix this.

nod_ → closed merge request !8991

Committed and pushed 3401675c3f to 11.x and 9006cbedab to 11.0.x and 14e9234d42 to 10.4.x and 6caa8062d0 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.