Warnings when using non-standard comment field formatter

Created on 23 May 2023, about 1 year ago

Updated 25 May 2023, about 1 year ago

I created a comment field formatter that doesn't load and render the whole comment thread, but when using it warnings are generated:

Warning: Undefined array key "comments" in comment_preprocess_field() (line 724 of core/modules/comment/comment.module).

Create a comment field formatter that doesn't provide the comments or comment_form variable to the field template.

Add checks to comment_preprocess_field to make sure the array indexes it's accessing actually exist.

🐛 Bug report

Status

Needs work

Version

9.5

Component

Comment →

Last updated 6 days ago

Created by

🇧🇪Belgium DieterHolvoet Brussels

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Comments & Activities

Issue created by @DieterHolvoet
Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Not currently mergeable.
@dieterholvoet opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
30,334 pass
Status changed to Needs review about 1 year ago4:13pm 23 May 2023
Comment about 1 year ago →
🇧🇪Belgium DieterHolvoet Brussels
Status changed to Needs work about 1 year ago10:01pm 25 May 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
As a bug will need a test showing the bug.

Would consider updating MR to 11.x as that's the current development branch. Code will be merged there first and backported.

Production build 0.69.0 2024