'@requires externalCommand' is not parsed in PHPUnit 10

Some thoughts from Slack summarised here:

We introduced this three years ago as a generic solution but in fact we only use it four times, each to check that Composer is available.

I suggest moving the check into ComposerBuildTestBase and making ComposerValidateTest extend that, or perhaps adding the check to ComposerIntegrationTrait.

The more generic solution that follows PHPUnit would be to introduce a #[RequiresExternalCommand] attribute similar to https://docs.phpunit.de/en/10.0/attributes.html#skipping-tests but given we haven't needed this for anything else I suspect this is overkill and ExternalCommandRequirementsTrait can be removed.

Thanks! I'm working on a solution based on a simple requirements check method.

To add to #3: it seems nothing in contrib uses this: http://grep.xnddx.ru/search?text=%40requires+externalCommand&filename=*T...

Do these instances need to be replaced too?

The ExternalCommandRequirementTest ones no, because they serve the purpose of checking the deprecation. But the ComponentsTaggedReleaseTest probably yes - although it looks like the check was never done for that test...

Rebased and fixed ComponentsTaggedReleaseTest.

LGTM.

As we only ever require Composer I think we can just make this even simpler?

trait RequiresComposerTrait {

  /**
   * @beforeClass
   */
  public static function requiresComposer() {
    $finder = new ExecutableFinder();
    if (!$finder->find('composer')) {
      static::markTestSkipped('This test requires Composer.');
    }
  }

}

You just add this trait to any class and it automatically skips if Composer is not available?

I have some doubts we can skip a test through a @beforeClass annotated method, but I got the gist of this. Need some trials.

I did a very rough trial locally and it seemed to work, so I am hopeful.

OK thanks, I will work on this.

Can't add a deprecation trigger for ExternalCommandRequirementsTrait as it would fire during test discovery when the bridge is not yet capturing deprecations. So added a trigger to all the trait's methods instead.

Looks great!

Committed/pushed to 11.x, thanks! (ignore the 10.1 commits...)

mondrake → closed merge request !4033

Automatically closed - issue fixed for 2 weeks with no activity.

Published the change record.