- Issue created by @wim leers
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:04pm 19 May 2023 - last update
over 1 year ago Patch Failed to Apply - π«π·France andypost
+++ b/src/Commands/InspectorCommands.php @@ -107,6 +118,12 @@ class InspectorCommands extends DrushCommands { + // Always inspect an up-to-date configuration schema. + $this->discoveryCache->deleteMultiple([ + 'typed_config_definitions', + 'validation_constraint_plugins', + ]);
maybe drush can decorate the service with memoryCache and always skip this keys on get()
- ππΊHungary GΓ‘bor Hojtsy Hungary
@andypost: I think its fine if we remove them from cache here, its a developer tool after all, so its more likely that you are tweaking the schema anyway, so it may be helpful in itself that it removes the schema cahes for the respective items?
- last update
over 1 year ago 3 pass - ππΊHungary GΓ‘bor Hojtsy Hungary
Rerolled the patch against the current codebase. Does this only affect Drush?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
#5: my thoughts exactly.
Does this only affect Drush?
Yes.
People using the Config Inspector UI would then indeed still get potentially stale information. But people may be using Config Inspector just to explore the values in their configuration. That's less likely in the Drush command.
So I figured that it would be potentially disruptive to do it also in the UI.
But β¦ happy to change that. I have no strong opinion.
- π«π·France andypost
btw Drush using own kernel additionally to core's one, but I totally agree that current delete is nice workaround without extra complexity
For UI part we can add a description or even hook_help for route with description pointing to performance settings page where caches can be cleared
- π«π·France andypost
It can be just a description for the checkbox (show only errors) at the top of list
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
That sounds reasonable to me. Note that we could even show when the config schema was constructed & cached, based on the
created
column for the relevant row in thecache_discovery
table! π€ - ππΊHungary GΓ‘bor Hojtsy Hungary
Hm is cache clearing a concern on the UI because it would do too much clearing or be detrimental to performance of the tool? I would prefer consistency in how the two interfaces to the module work, otherwise you would get different results on the UI and in Drush, that could quickly get confusing.
- Assigned to wim leers
- Status changed to Needs work
over 1 year ago 12:51pm 22 May 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Hm is cache clearing a concern on the UI because it would do too much clearing
This.
or be detrimental to performance of the tool
Not this. Config Inspector itself still does the same exact amount of work either way.
I would prefer consistency in how the two interfaces to the module work, otherwise you would get different results on the UI and in Drush, that could quickly get confusing.
WFM!
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:21pm 22 May 2023 - last update
over 1 year ago 3 pass - ππΊHungary GΓ‘bor Hojtsy Hungary
Retitle for the more general solution arrived at.
- e4e5d76e committed on 2.1.x
Issue #3361559 by Wim Leers, GΓ‘bor Hojtsy, andypost: Config inspection...
- e4e5d76e committed on 2.1.x
- Status changed to Fixed
over 1 year ago 7:10am 23 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.