Contrib.social

hide_discard_revert_buttons broken

Open on Drupal.org →
Created on 18 May 2023, about 1 year ago
Updated 26 June 2023, about 1 year ago

Problem/Motivation

You can't choose to show / hide the discard and revert buttons as the config form is broken.

Steps to reproduce

- Go to settings: /admin/config/gin_lb/settings
- Toggle setting for 'Hide "Discard changes" and "Revert to defaults" buttons'
- Save form

The setting wont save and the setting also doesn't change anything with regards to the buttons.

Proposed resolution

Fix the typos in the form and save the setting.

Remaining tasks

The form element key is missing an 's' and needs to look like this

$form['hide_discard_revert_buttons'] ...
...      
 '#default_value' => $config->get('hide_discard_revert_buttons'),

And it needs this in the submit:

      ->set('hide_discard_revert_buttons', $form_state->getValue('hide_discard_revert_buttons'))
🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom very_random_man

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024