Fix the issues reported by phpcs

Working on it.

Open MR1 for the fixes.

Remaining issues are:

FILE: /home/system/Documents/contribution/safedelete-3360570/src/AdminHelper.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 10 WARNINGS AFFECTING 22 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  15 | ERROR   | Doc comment is empty
  20 | ERROR   | Doc comment is empty
  27 | ERROR   | Doc comment is empty
  30 | ERROR   | Variable "DEBUG" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed
  32 | ERROR   | Variable "DEBUG" starts with a capital letter, but only $lowerCamelCase or $snake_case is allowed
  64 | WARNING | Line exceeds 80 characters; contains 82 characters
  82 | ERROR   | Public method name "AdminHelper::_latest_revision" is not in lowerCamel format
 135 | ERROR   | Parameter $current_uid is not described in comment
 244 | WARNING | Only string literals should be passed to t() where possible
 261 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
 358 | WARNING | Only string literals should be passed to t() where possible
 470 | WARNING | Only string literals should be passed to t() where possible
 580 | WARNING | Line exceeds 80 characters; contains 128 characters
 596 | WARNING | Line exceeds 80 characters; contains 81 characters
 600 | WARNING | Empty return statement not required here
 603 | ERROR   | Doc comment is empty
 667 | ERROR   | sizeof() is a function name alias, use count() instead
 700 | WARNING | Line exceeds 80 characters; contains 107 characters
 727 | WARNING | Empty return statement not required here
 730 | ERROR   | Doc comment is empty
 740 | ERROR   | Doc comment is empty
 750 | ERROR   | Doc comment is empty
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/safedelete-3360570/src/Controller/SearchingOrphanedPageController.php
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
  11 | ERROR   | Doc comment is empty
  34 | ERROR   | Doc comment is empty
  45 | ERROR   | Description for the @return value is missing
  52 | WARNING | Line exceeds 80 characters; contains 114 characters
 125 | ERROR   | Doc comment is empty
---------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/safedelete-3360570/safedelete.module
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AND 16 WARNINGS AFFECTING 22 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  29 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
     |         | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  30 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  69 | WARNING | Line exceeds 80 characters; contains 88 characters
 130 | WARNING | Line exceeds 80 characters; contains 140 characters
 159 | WARNING | Line exceeds 80 characters; contains 81 characters
 267 | WARNING | Line exceeds 80 characters; contains 83 characters
 553 | ERROR   | Invalid function name, expected _handle_insert_file_usage_page_creation but found _handleInsertFileUsage_PageCreation
 553 | ERROR   | All functions defined in a module file must be prefixed with the module's name, found "_handleInsertFileUsage_PageCreation" but expected "safedelete__handleInsertFileUsage_PageCreation"
 558 | WARNING | Line exceeds 80 characters; contains 88 characters
 616 | ERROR   | Doc comment is empty
 619 | ERROR   | Invalid function name, expected batch_process_nodes_op but found batch_ProcessNodes_Op
 619 | ERROR   | All functions defined in a module file must be prefixed with the module's name, found "batch_ProcessNodes_Op" but expected "safedelete_batch_ProcessNodes_Op"
 630 | ERROR   | sizeof() is a function name alias, use count() instead
 661 | WARNING | Line exceeds 80 characters; contains 105 characters
 697 | ERROR   | Invalid function name, expected batch_process_nodes_finished but found batch_ProcessNodes_finished
 697 | ERROR   | All functions defined in a module file must be prefixed with the module's name, found "batch_ProcessNodes_finished" but expected "safedelete_batch_ProcessNodes_finished"
 703 | WARNING | Line exceeds 80 characters; contains 95 characters
 704 | WARNING | Line exceeds 80 characters; contains 95 characters
 735 | WARNING | Hook implementations should not duplicate @param documentation
 735 | ERROR   | Missing parameter name
 759 | WARNING | Hook implementations should not duplicate @param documentation
 759 | ERROR   | Missing parameter name
 788 | WARNING | Line exceeds 80 characters; contains 82 characters
 815 | WARNING | Only string literals should be passed to t() where possible
 820 | WARNING | Only string literals should be passed to t() where possible
 846 | WARNING | Only string literals should be passed to t() where possible
 851 | WARNING | Only string literals should be passed to t() where possible
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 185ms; Memory: 14MB

FILE: /home/system/Documents/contribution/safedelete-3360570/src/AdminHelper.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 21 WARNINGS AFFECTING 21 LINES
--------------------------------------------------------------------------------
  68 | WARNING | Unused variable $language.
 169 | WARNING | Unused variable $message.
 173 | WARNING | Unused variable $langcode.
 191 | WARNING | Unused variable $key.
 248 | WARNING | Unused variable $key.
 297 | WARNING | Unused variable $message.
 301 | WARNING | Unused variable $langcode.
 305 | WARNING | Unused variable $node_storage.
 362 | WARNING | Unused variable $key.
 407 | WARNING | Unused variable $message.
 411 | WARNING | Unused variable $langcode.
 417 | WARNING | Unused variable $node_storage.
 478 | WARNING | Unused variable $key.
 518 | WARNING | Unused variable $parentMenuLink.
 548 | WARNING | Unused variable $node_storage.
 567 | WARNING | Unused variable $node_storage.
 592 | WARNING | Unused variable $querydelete.
 656 | WARNING | Unused variable $filearraynid.
 670 | WARNING | Unused variable $moderation_state.
 702 | WARNING | Unused variable $ntype.
 830 | WARNING | Unused variable $moderation_state.
--------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/safedelete-3360570/src/Controller/SearchingOrphanedPageController.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------------------
  49 | WARNING | Unused variable $rountingname.
  49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  58 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  84 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  88 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  89 | WARNING | Unused variable $filearraynid.
  97 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  98 | WARNING | Unused variable $key.
 130 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/safedelete-3360570/src/Form/SafedeleteSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 31 WARNINGS AFFECTING 30 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  35 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
  50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  73 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 163 | WARNING | Unused variable $reporteddate.
 164 | WARNING | Unused variable $orphanedpages_results.
 166 | WARNING | Unused variable $database.
 166 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 167 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
 180 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 185 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 196 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 215 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 217 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 221 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 222 | WARNING | Unused variable $filearraynid.
 225 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/safedelete-3360570/safedelete.module
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
------------------------------------------------------------------------------
 132 | WARNING | Unused variable $difcount.
 142 | WARNING | There must be no blank line following an inline comment
 210 | WARNING | Unused variable $node_storage.
 236 | WARNING | Unused variable $node_storage.
 353 | WARNING | Unused variable $langcode.
 364 | WARNING | Unused variable $fid.
 409 | WARNING | Unused variable $langcode.
 467 | WARNING | Unused variable $langcode.
 505 | WARNING | Unused variable $field_type.
 663 | WARNING | Unused variable $ntype.
 685 | WARNING | Unused variable $file.
 745 | WARNING | Unused variable $error_message.
 763 | WARNING | Unused variable $state.
 831 | WARNING | Unused variable $delta.
------------------------------------------------------------------------------

Time: 174ms; Memory: 12MB

The MR has conflicts due to recent changes made in

Rebased the changes as per #8.

Thanks again

Tagged release with the above changes:
https://www.drupal.org/project/safedelete/releases/1.0.43 →

Automatically closed - issue fixed for 2 weeks with no activity.

found a regression

fixed regression

commit 8b141b1ae0c17ed22d01bc35611b397cdfe07790 (HEAD -> 1.0.x, origin/HEAD, origin/1.0.x)
Author: Joseph Olstad <20895-joseph.olstad@users.noreply.drupalcode.org>
Date:   Mon Sep 11 12:10:12 2023 -0400

    Issue #3360570 by joseph.olstad: Fix the issues reported by phpcs

Automatically closed - issue fixed for 2 weeks with no activity.