TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm

TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() (line 198 of /var/www/cloud_orchestrator/docroot/core/modules/user/src/Form/UserPermissionsForm.php) #0 /var/www/cloud_orchestrator/docroot/core/modules/user/src/Form/UserPermissionsForm.php(198): in_array('add aws cloud i...', NULL) #1 [internal function]: Drupal\user\Form\UserPermissionsForm->buildForm(Array, Object(Drupal\Core\Form\FormState)) #2 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(536): call_user_func_array(Array, Array) #3 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/Form/FormBuilder.php(283): Drupal\Core\Form\FormBuilder->retrieveForm('user_admin_perm...', Object(Drupal\Core\Form\FormState)) #4 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\user\Form\UserPermissionsForm), Object(Drupal\Core\Form\FormState)) #5 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #6 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #7 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #8 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #9 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #10 /var/www/cloud_orchestrator/vendor/symfony/http-kernel/HttpKernel.php(169): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #11 /var/www/cloud_orchestrator/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #12 /var/www/cloud_orchestrator/docroot/modules/contrib/simple_oauth/src/HttpMiddleware/BasicAuthSwap.php(68): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #13 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #14 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #15 /var/www/cloud_orchestrator/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #16 /var/www/cloud_orchestrator/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #17 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #18 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /var/www/cloud_orchestrator/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /var/www/cloud_orchestrator/docroot/core/lib/Drupal/Core/DrupalKernel.php(718): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #21 /var/www/cloud_orchestrator/docroot/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #22 {main}

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @yas
Merge request !3997Issue #3360562: TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm → (Open) created by yas
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass
Status changed to Needs review over 1 year ago5:07am 16 May 2023
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
We can simply add a Null coalescing operator like:

'#default_value' => in_array($perm, $role_permissions[$rid] ?? []) ? 1 : 0,
But I put !empty($role_permissions[$rid]) ? $role_permissions[$rid] : [] since we should consider the case of an empty string.
Comment over 1 year ago →
cilefen
Why do you make permissions: NULL in user.role.authenticated.yml?
Comment over 1 year ago →
🇺🇸United States yas California 🇺🇸
@cilefen

My team member who is new to Drupal accidentally put Permissions: NULL in user.role.authenticated.yml and imported it to a site. Drupal experts won't be likely to do that because we all know about Drupal; however on the other hand someone will possibly do the same in the future. It was something like a manual negative test and we found a kind of bug of Drupal core which expects a valid input data. We should make Drupal core more robust.
Status changed to Needs work over 1 year ago11:37am 16 May 2023
Comment over 1 year ago →
cilefen
We have had many workaround patches like this offered now that PHP 8 is in use.

It would actually be better to throw an exception for a wrong data type than to silently allow it.
Comment over 1 year ago →
🇬🇧United Kingdom oily Greater London
andrew.farquharson → made their first commit to this issue’s fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,364 pass, 4 fail
@andrewfarquharson opened merge request.
Comment over 1 year ago →
🇬🇧United Kingdom oily Greater London
Comment over 1 year ago →
🇬🇧United Kingdom oily Greater London
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,388 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,420 pass
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Not currently mergeable.
@andrewfarquharson opened merge request.
Status changed to Needs review over 1 year ago5:53pm 11 June 2023
Comment over 1 year ago →
🇬🇧United Kingdom oily Greater London
The Unit test does not seem necessary. Manual testing seems the simplest method. Just manually edit the user.role.authenticated.yml file and set 'permissions: NULL'. Then access the admin permissions form and refer to 'recent log messages' under admin/reports and look for the InvalidArgument Exception message. No errors should be generated.
Status changed to Needs work over 1 year ago6:05pm 11 June 2023
Comment over 1 year ago →
🇬🇧United Kingdom oily Greater London
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Not currently mergeable.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
29,425 pass, 1 fail
Comment about 1 year ago →
🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
@cilefen #6 🐛 TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm Needs work yeah I can't find them at this very moment but we had some of this issues lately and discussed many of it in Slack with the same conclusion: it would be better to handle it with an exception and a log to prevent WSOD but without let it pass silently so that admin know that there is sth to fix.
Comment about 1 year ago →
🇮🇳India ameymudras
Do we really need to fix this issue? user.role.authenticated.yml should always be system generated as opposed to making manual changes.
Comment about 1 year ago →
🇳🇴Norway svenryen
This patch probably won't make it into core, due to the lack of a test.

I'm adding it here, since we saw additional fatal crashes in another file where in_array() was being used on a NULL value, and it might help others facing the same bug.

TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!3997TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm
Open

Comments & Activities

TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!3997TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsFormOpen

Comments & Activities

!3997TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in in_array() in Drupal\user\Form\UserPermissionsForm
Open