Fix the issues reported by phpcs

Created on 12 May 2023, about 1 year ago
Updated 7 June 2024, 21 days ago
📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India Shanu Chouhan

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Shanu Chouhan
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • 🇮🇳India Shanu Chouhan

    I have Created a patch to fix this issue

  • 🇺🇸United States edwardmonk
  • 🇺🇸United States edwardmonk
  • Status changed to Needs work about 1 year ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

    The command in the issue summary is not showing the correct value for --standard: Drupal/web/modules/contrib/smithsonian_open_access/ is eventually the directory containing the module.

  • Status changed to Needs review about 1 year ago
  • 🇮🇳India Ashutosh Ahirwal India

    I have updated the issue summary with command and arguments.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs work 21 days ago
  • Hi @Shanu Chouhan,

    Failed to apply your patch. Please see below:

    smithsonian_open_access git:(1.0.x) curl https://www.drupal.org/files/issues/2023-05-12/3359984-2.patch
    | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 17021  100 17021    0     0  54384      0 --:--:-- --:--:-- --:--:-- 56360
    patching file js/form_behaviors.js
    Hunk #1 FAILED at 2.
    Hunk #2 FAILED at 10.
    2 out of 2 hunks FAILED -- saving rejects to file js/form_behaviors.js.rej
    patching file src/Api.php
    Hunk #1 succeeded at 1 with fuzz 2.
    Hunk #8 FAILED at 178.
    Hunk #9 FAILED at 201.
    Hunk #10 succeeded at 247 (offset 19 lines).
    Hunk #11 succeeded at 259 (offset 19 lines).
    Hunk #12 succeeded at 271 (offset 19 lines).
    Hunk #13 succeeded at 291 (offset 19 lines).
    Hunk #14 succeeded at 310 (offset 19 lines).
    Hunk #15 succeeded at 322 (offset 19 lines).
    Hunk #16 succeeded at 331 (offset 19 lines).
    2 out of 16 hunks FAILED -- saving rejects to file src/Api.php.rej
    patching file src/Form/SmithsonianOpenAccessSettingsForm.php
    Hunk #1 FAILED at 10.
    Hunk #2 FAILED at 58.
    Hunk #3 FAILED at 214.
    Hunk #4 FAILED at 240.
    Hunk #5 FAILED at 262.
    Hunk #6 FAILED at 271.
    Hunk #7 FAILED at 301.
    Hunk #8 FAILED at 331.
    Hunk #9 FAILED at 364.
    9 out of 9 hunks FAILED -- saving rejects to file src/Form/SmithsonianOpenAccessSettingsForm.php.rej
    patching file src/Form/SmithsonianOpenAccessTestForm.php
    Hunk #1 FAILED at 8.
    Hunk #2 FAILED at 44.
    Hunk #3 FAILED at 140.
    Hunk #4 FAILED at 166.
    Hunk #5 FAILED at 212.
    5 out of 5 hunks FAILED -- saving rejects to file src/Form/SmithsonianOpenAccessTestForm.php.rej

    Kindly check.

    Thanks,
    Jake

  • Pipeline finished with Success
    21 days ago
    Total: 150s
    #193539
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
Production build 0.69.0 2024