- Issue created by @sidharth_soman
- 🇮🇳India sidharth_soman Bangalore
I am working on this and will provide an MR.
- @sidharth_soman opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:14pm 11 May 2023 - Status changed to Needs work
almost 2 years ago 3:25pm 19 May 2023 - 🇵🇭Philippines kenyoOwen
Hi sidharth_soman
I applied your MR to the “Sitemap Status” module and confirmed that the phpcs issue mentioned is resolved in that file, but the error appears also in SettingsForm.php maybe fix it also.
FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/sitemap_status/src/Form/SettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 7 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
70 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
168 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
248 | WARNING | [x] There must be no blank line following an inline comment
248 | WARNING | [ ] There must be no blank line following an inline comment
252 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
286 | ERROR | [ ] Missing parameter comment
287 | ERROR | [ ] Missing parameter comment
293 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLYPlease see the screenshots attached.
For your review.
Thank you. - 🇮🇳India ashutosh ahirwal India
Ashutosh Ahirwal → made their first commit to this issue’s fork.
- @ashutosh-ahirwal opened merge request.
- Status changed to Needs review
almost 2 years ago 11:48am 13 June 2023