- Issue created by @kubokura
- Assigned to sunidhinegi31
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:51am 27 August 2023 - 🇫🇷France dydave
Hi everyone,
Thank you very much for raising this issue and suggesting the changes needed, it's greatly appreciated.
After taking a closer look in the issue queue, it appears this particular ticket is conflicting with the work that was done previously in ✨ anyLabel is set up even if there is only one element in the list Fixed , with the following change:
https://git.drupalcode.org/project/shs/-/commit/e0847eb9c10182ac0057f298...As suggested in the issue summary, roling back these changes seems to fix the problem.
Please find attached to this reply a patch on '2.0.x':
shs-support-anylabel-for-single-select-value-3359292-4.patch →We would greatly appreciate if you could please try testing the patch and let us know if you encounter any issues.
Feel free to let us know if you have any questions on the patch, or this ticket in general, we would be glad to provide more information.
Thanks in advance! Hi DYdave-san, thank you for the patch.
The patch works for me. Terms appear correctly instead of blank.
(It seems the patch conflicts with 4.diff on https://www.drupal.org/project/shs/issues/3269746 🐛 "- Select a value -" appears at bottom of lists RTBC , so I have needed to edit js/views/WidgetView.js manually.)- Status changed to RTBC
about 1 year ago 4:34pm 24 September 2023 - 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks for the patch.
Applied and it fixed the problem.
- 🇬🇧United Kingdom rossb89 Bristol
Thanks for the work here. I also had the same issue as @kubokura in that I need this patch and the MR patch from #3269746 as well really and they are both modifying the same line.
I've created a combo patch if anyone finds they need both patches really (I can't see why you wouldn't need both!) which will suffice until such time one is merged and then the other can be patched cleanly and merged :)