- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:24pm 9 May 2023 - First commit to issue fork.
- @dineshkumarbollu opened merge request.
- ๐ฎ๐ณIndia dineshkumarbollu
Hi
The patch#2 applied cleanly but found 1 phpcbf warning that is fixed in the MR.
Thanks.
- Status changed to Needs work
over 1 year ago 10:58am 10 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** * @file - * * Hook implementations. */
Since that comment is edited, the description should be changed too. (Hook implementations for the Secure html module.)
/** + * A filter that Wraps content in an iframe. + *
Wraps is misspelled, since it has been capitalized when it should not.
Also, the report shown in the issue summary is for a single file, but the MR changes two files. Either the report is updated or the MR changes what the report says to change.
- Status changed to Needs review
over 1 year ago 11:23am 10 May 2023 - ๐ฎ๐ณIndia dineshkumarbollu
Hi
I changed the 2 comment which reported above, while running phpcs command before applying patch changes are in 2 files.Thanks
- Status changed to Needs work
over 1 year ago 12:41pm 10 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ /** ++ * A filter that Wraps content in an iframe. ++ * + * @Filter(
+- list($k, $v) = explode("=", $str); ++ [$k, $v] = explode("=", $str);
+ public function settingsForm(array $form, FormStateInterface $form_state) { +- $form['secure_html_settings'] = array( ++ $form['secure_html_settings'] = [
There are extra plus/minus signs that need to be removed.
- * Hook implementations. + * Hook implementations for the Secure html module..
There are two periods at the end of the description instead of one.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:34am 11 May 2023 - Status changed to Needs work
over 1 year ago 7:55am 11 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** * @file - * - * Hook implementations. + * Hook implementations for Secure HTML module. */
The module name is Secure html, not Secure HTML.
A definite article is missing after for.The report shows warnings/errors for a single file, but the patch changes two files. Either the patch changes only the file for which the issue summary reports warnings/errors or the report is changed to reflect the changes done.
- Status changed to Needs review
over 1 year ago 8:43am 11 May 2023 - First commit to issue fork.
-
anrkaid โ
committed 06564578 on 1.0.x authored by
imustakim โ
Issue #3359098 by dineshkumarbollu, imustakim, Shanu Chouhan, anrkaid,...
-
anrkaid โ
committed 06564578 on 1.0.x authored by
imustakim โ
- Status changed to Fixed
over 1 year ago 6:56am 17 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.