Claro: Media Dialog Box Too Small

Created on 8 May 2023, over 1 year ago
Updated 3 May 2024, 8 months ago

Media Dialog Box too small, happen both on Portrait and Landscape mobile phone (see attached pictures).

Current solution is add custom CSS:

.media-library-widget-modal .ui-dialog-content {
	height: 700px !important;
}

🐛 Bug report
Status

Closed: cannot reproduce

Version

11.0 🔥

Component
Claro 

Last updated 2 days ago

Created by

🇮🇩Indonesia drupalnesia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @drupalnesia
  • Assigned to Kaustab_Roy
  • 🇮🇳India Kaustab_Roy

    looking at the issue.

  • Issue was unassigned.
  • 🇮🇳India Kaustab_Roy

    @drupalnesia i think the root cause of the issue due to ckeditor5 js.

    It sets the following:
    dialogSettings.autoResize = window.matchMedia('(min-width: 600px)').matches;
    dialogSettings.width = 'auto';

    Hence under 600px the default behavior of dialog to resize is not working.
    And this overrides the default dialog.position.js autoResize & width property.
    I have checked it by removing them from ckeditor5.js file.
    it works ! ( screenshot added)

    I currently didn't find why it has been done on ckeditor, but i think , it can be related to provide the ability to resize using the resize tool under 600px, but the jquery resizable doesn't works with touch devices though.
    https://jqueryui.com/resizable/

    So, under current circumstances, your proposed solution of providing custom css to override the height will work, but might not be optimal.

    Any of the core maintainers need to check this once.
    Thanks.

  • 🇮🇳India Harish1688 India

    Hi,
    I am unable to replicate the issue with Claro and Ckeditor5 on the same version, both in Landscape and Portrait modes. Are there any additional steps or specific devices that need to be considered in order to reproduce the issue?

  • 🇮🇩Indonesia drupalnesia

    @harish1688 Look like you may only allow 1 media, try to enable: Audio, Document, Image, Remote video and Video.

  • Status changed to Closed: cannot reproduce 8 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    The media dialog appears to be making good use of the available vertical space

    If you have steps on how to reproduce on a fresh install (an Umami install might be easiest since Media Library is already set up), put that in the issue summary and reopen

    Btw I noticed the workaround of mentioned in the issue summary sets the dialog content to a fixed height of 700px. This means on taller screens you are unable to take advantage of the available height.

    .media-library-widget-modal .ui-dialog-content {
    	height: 700px !important;
    }

    You may find the vh unit more helpful as it is a percentage of the available height, not a fixed pixel value.

Production build 0.71.5 2024