Fix Coding Standards

Created on 5 May 2023, over 1 year ago
Updated 3 September 2023, over 1 year ago

Problem/Motivation

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/config_profile/

FILE: /var/www/html/vbd9/web/modules/contrib/config_profile/src/Form/Settings.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
11 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vbd9/web/modules/contrib/config_profile/src/Plugin/ConfigFilter/ProfileFilter.php
----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Doc comment short description must end with a full stop
23 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
104 | ERROR | [ ] Missing parameter comment
105 | ERROR | [ ] Missing parameter comment
105 | ERROR | [ ] Missing parameter type
106 | ERROR | [ ] Missing parameter comment
106 | ERROR | [ ] Missing parameter type
107 | ERROR | [ ] Missing parameter comment
127 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
127 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
138 | ERROR | [ ] Missing parameter type
146 | WARNING | [ ] The use of function fnmatch() is discouraged
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vbd9/web/modules/contrib/config_profile/config_profile.info.yml
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

FILE: /var/www/html/vbd9/web/modules/contrib/config_profile/config_profile.links.menu.yml
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: /var/www/html/vbd9/web/modules/contrib/config_profile/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
11 | WARNING | Line exceeds 80 characters; contains 314 characters
19 | WARNING | Line exceeds 80 characters; contains 309 characters
27 | WARNING | Line exceeds 80 characters; contains 398 characters
28 | WARNING | Line exceeds 80 characters; contains 316 characters
29 | WARNING | Line exceeds 80 characters; contains 110 characters
33 | WARNING | Line exceeds 80 characters; contains 220 characters
----------------------------------------------------------------------

Time: 340ms; Memory: 12MB

Steps to reproduce

Proposed resolution

RUN:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/config_profile/

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇳India dineshkumarbollu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024