- Issue created by @sakthi_dev
- 🇮🇳India sakthi_dev
Maintainer please create a tag for the Drupal 10 release.
- Status changed to Postponed: needs info
over 1 year ago 6:38pm 4 May 2023 - 🇫🇷France fgm Paris, France
dev-8.x-1.x is supposed to be compatible with D10.
If you consider it is not, please explain what compatibility issue you encounter. If there is none, you can just request dev-8.x-2.x and get the compatible version.
- 🇮🇳India Shiv_Sharma
@sakthi_dev able to install dev-8.x-1.x in drupal 10
attached screenshot for reference.
- Status changed to Active
over 1 year ago 11:54am 9 May 2023 - 🇦🇺Australia dpi Perth, Australia
@fgm per 2 I think theyre specifically requesting a tagged release. The latest, beta3 is only for 8 & 9.
- Issue was unassigned.
- 🇳🇱Netherlands megachriz
Oops, I didn't get notifications for this issue. I planned to get 🐛 Passing null to parameter #1 ($string) of type string is deprecated in xmlrpc_value_get_xml() Fixed in first before creating a release, but other stuff got in the way the past few weeks.
- 🇳🇱Netherlands megachriz
I've made some commits and I deployed the dev version on a live site. I'll be monitoring that site for a week or so to see if any new issues come up. If I find none, I'll create a new release. :)
- 🇳🇱Netherlands megachriz
I think it is ready for release now, but unfortunately I have no privileges to create a new release.
@fgm
Can you give me the permission to create a new release? I pushed a tag called 8.x-1.0-rc1.I've written the following release notes:
Drupal 10 support, bug fixes
This release add compatibility with Drupal 10.
Other changes
XML-RPC server
- A method provided via
hook_xmlrpc()
now only requires a method name and a callback. A signature (the method's return value and its parameters) and a help message are optional. - If a method does not provide a signature, then a call to "system.methodSignature" no longer results into an error, but instead it says that the method's signature is "undef".
- Callbacks from a method defined via
hook_xmlrpc()
can now also be a method from a class. - Constants for XML-RPC error codes are added to xmlrpc.server.inc.
XML-RPC client
- When a parameter from a call to
xmlrpc()
is null, in the XML that gets send, it results into the tag<nil / >
.
Contributors (9)
MegaChriz → , Charchil Khandelwal → , Akram Khan → , noorulshameera → , apaderno → , fgm → , Anmol_Specbee → , Project Update Bot → , mirondi →
Changelog
Issues: 4 issues resolved.
Changes since 8.x-1.0-beta3 → :
Bug
- #897130 → by MegaChriz → : Fixed system.methodSignature should return "undef" instead of error -32601.
- #3355068 → by MegaChriz → : Use 'nil' element when value is NULL to fix PHP 8.1 notice.
Task
- #3329633 → by MegaChriz → , Charchil Khandelwal → , Akram Khan → , noorulshameera → , apaderno → , fgm → , Anmol_Specbee → : Fixed phpcs coding standards.
- #3290729 → by MegaChriz → , Project Update Bot → , mirondi → : Made project compatible with Drupal 10.
- A method provided via
- Status changed to Fixed
over 1 year ago 7:14am 14 June 2023 - 🇳🇱Netherlands megachriz
Thanks, @fgm!
A new release has been made: 8.x-1.0-rc1 → . This might become the 8.x-1.0 version as well if no new issues are discovered.
- 🇫🇷France fgm Paris, France
Just an idea: https://www.drupal.org/project/g2/releases/8.x-1.x-dev → includes a legacy hook_xmlrpc based XML-RPC implementation.
It would be interesting to check if it is compatible with this contrib release.
- 🇳🇱Netherlands megachriz
Based on the code, it looks like that would work. The format
'method name' => 'callback'
is covered by tests.The only line I'm not sure about is:
'g2.random' => [\Drupal::service(G2::SVC_RANDOM), 'get'],
Because without inspecting the code further, I don't know what
\Drupal::service(G2::SVC_RANDOM)
returns. If it returns a class name or an object I do expect it to work. Ifis_callable([\Drupal::service(G2::SVC_RANDOM), 'get'])
returnsTRUE
I expect thatcall_user_func_array([\Drupal::service(G2::SVC_RANDOM), 'get'], $args)
would just work. Seexmlrpc_server_call()
. Automatically closed - issue fixed for 2 weeks with no activity.