- Issue created by @MegaChriz
- Merge request !4Issue #3355068: Passing null to parameter #1 ($string) of type string is deprecated in xmlrpc_value_get_xml() → (Closed) created by MegaChriz
- last update
over 1 year ago 24 pass - @megachriz opened merge request.
- last update
over 1 year ago 14 pass, 1 fail - Status changed to Needs review
over 1 year ago 9:11am 19 April 2023 - 🇳🇱Netherlands MegaChriz
Hm, the actual expected data is not displayed correctly on https://www.drupal.org/pift-ci-job/2646968 →
But it can be found here:
https://dispatcher.drupalci.org/job/drupal8_contrib_patches/153516/artif...<failure type="PHPUnit\Framework\ExpectationFailedException"> Drupal\Tests\xmlrpc\Unit\ValueTest::testValueGetXml with data set #5 ('<nil />', null) Failed asserting that two DOM documents are equal. --- Expected +++ Actual @@ @@ <?xml version="1.0"?> -<nil/> +<string/> /var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:96 /var/www/html/modules/contrib/xmlrpc/tests/src/Unit/ValueTest.php:28 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:675 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:675 /var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:653 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144 /var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97 </failure>
I don't see the deprecated warning displayed on the testbot, but I did see it locally:
Other deprecation notices (1)
1x: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
1x in ValueTest::testValueGetXml from Drupal\Tests\xmlrpc\Unit - last update
over 1 year ago 24 pass -
MegaChriz →
committed 0a613a4b on 8.x-1.x
Issue #3355068 by MegaChriz: Use 'nil' element when value is NULL to fix...
-
MegaChriz →
committed 0a613a4b on 8.x-1.x
- Status changed to Fixed
over 1 year ago 7:36am 6 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.