PHP 8.2 compatibility

Issue created by @vishalkhode
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update about 1 year ago
51 pass
@sakthi_dev opened merge request.
Comment about 1 year ago →
System Message
smustgrave → closed merge request !42
Comment about 1 year ago →
🇺🇸United States smustgrave
Removing credit for the MR as it seemed to be trying to merge 8.x-1.x branch into 2.x.
First commit to issue fork.
Assigned to ankitv18
Comment about 1 year ago →
🇮🇳India ankitv18
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Not currently mergeable.
@deepakkm opened merge request.
Assigned to deepakkm
Comment about 1 year ago →
🇮🇳India deepakkm
Comment about 1 year ago →
🇮🇳India deepakkm
Looks like this issue is from scheduler module.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
51 pass
Issue was unassigned.
Status changed to Needs review about 1 year ago5:36am 23 May 2023
Comment about 1 year ago →
🇮🇳India deepakkm
Assigned to ankitv18
Comment about 1 year ago →
🇮🇳India ankitv18
Status changed to Needs work about 1 year ago6:04am 23 May 2023
Comment about 1 year ago →
🇮🇳India ankitv18
Below deprecations still there:
15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$restrictedUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional

15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$schedulerMediaUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional

15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$restrictedMediaUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
51 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
51 pass
Issue was unassigned.
Status changed to Needs review about 1 year ago7:21am 23 May 2023
Comment about 1 year ago →
🇮🇳India ankitv18
Please review MR!44 it is ready now.
Status changed to RTBC about 1 year ago8:10am 23 May 2023
Comment about 1 year ago →
🇮🇳India Rajeshreeputra Pune
Changes looks good and CI passing for 8.1 and 8.2 both, hence moving to RTBC.
Status changed to Needs work 12 months ago6:00pm 17 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
Error and fix don't line up.

If this is just a phpcs fix then will close out, and will address later.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
51 pass
Status changed to RTBC 12 months ago9:20am 21 June 2023
Comment 12 months ago →
🇮🇳India Rajeshreeputra Pune
@smustgrave it is not related to the phpcs fix, it's related to the deprecation of using dynamic properties.

Hence this needs to be fixed.
Status changed to Needs work 12 months ago11:38am 21 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
Then issue summary should be updated
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 12 months ago
51 pass
Comment 12 months ago →
🇬🇧United Kingdom jonathan1055
Given that this issue is all about PHP8.2 compatibility I thought it would be useful to actually run the MR test at PHP8.2. So I've queded that up.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update 12 months ago
26 pass, 3 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 12 months ago
39 pass, 3 fail
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
last update 11 months ago
26 pass, 3 fail
Comment 18 days ago →
🇺🇸United States smustgrave

Problem/Motivation

Comments & Activities