- Issue created by @vishalkhode
- First commit to issue fork.
- last update
almost 2 years ago 51 pass - @sakthi_dev opened merge request.
- 🇺🇸United States smustgrave
Removing credit for the MR as it seemed to be trying to merge 8.x-1.x branch into 2.x.
- First commit to issue fork.
- Assigned to ankitv18
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Not currently mergeable. - Assigned to deepakkm
- last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:36am 23 May 2023 - Assigned to ankitv18
- Status changed to Needs work
almost 2 years ago 6:04am 23 May 2023 - 🇮🇳India ankitv18
Below deprecations still there:
15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$restrictedUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$schedulerMediaUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional15x: Creation of dynamic property Drupal\Tests\scheduler_content_moderation_integration\Functional\FormsTest::$restrictedMediaUser is deprecated
4x in FormsTest::testEntityFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testHideSchedulerFields from Drupal\Tests\scheduler_content_moderation_integration\Functional
4x in FormsTest::testFormAlterWithDeniedAccess from Drupal\Tests\scheduler_content_moderation_integration\Functional
3x in FormsTest::testEntityTypeFormAlter from Drupal\Tests\scheduler_content_moderation_integration\Functional - last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - last update
almost 2 years ago 51 pass - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:21am 23 May 2023 - Status changed to RTBC
almost 2 years ago 8:10am 23 May 2023 - 🇮🇳India rajeshreeputra Pune
Changes looks good and CI passing for 8.1 and 8.2 both, hence moving to RTBC.
- Status changed to Needs work
almost 2 years ago 6:00pm 17 June 2023 - 🇺🇸United States smustgrave
Error and fix don't line up.
If this is just a phpcs fix then will close out, and will address later.
- last update
almost 2 years ago 51 pass - Status changed to RTBC
almost 2 years ago 9:20am 21 June 2023 - 🇮🇳India rajeshreeputra Pune
@smustgrave it is not related to the phpcs fix, it's related to the deprecation of
using dynamic properties.Hence this needs to be fixed.
- Status changed to Needs work
almost 2 years ago 11:38am 21 June 2023 - last update
almost 2 years ago 51 pass - 🇬🇧United Kingdom jonathan1055
Given that this issue is all about PHP8.2 compatibility I thought it would be useful to actually run the MR test at PHP8.2. So I've queded that up.
- last update
almost 2 years ago 26 pass, 3 fail - last update
almost 2 years ago 39 pass, 3 fail - last update
almost 2 years ago 26 pass, 3 fail - 🇺🇸United States smustgrave
Thanks everyone but don't think this is needed anymore actually. The pipeline is running 8.3 and I don't see any problems there.