- Issue created by @himanshu_jhaloya
- š®š³India msankhala Bikaner, Rajasthan
This will be fixed in the stable version. This is still in beta release. I would appreciate the real bug fix instead of just coding standard fix.
- š®š³India himanshu_jhaloya Indore
@msankhala Ok thanks for the update. can I add the patch it will be helpful
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:30pm 2 May 2023 - š®š³India msankhala Bikaner, Rajasthan
Fixed in 1.1.x dev branch. This will reflect in the next beta release. There are a couple of warnings that can be ignored as of now.
- Status changed to Needs work
4 months ago 10:07am 21 August 2024 - šµšPhilippines cleavinjosh
Hi @msankhala,
I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
on 1.1.x branch and there are still some errors I encountered:ā contrib cd elastic_enterprise_search ā elastic_enterprise_search git:(1.1.x) .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig elastic_enterprise_search FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/README.md -------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 19 WARNINGS AFFECTING 19 LINES -------------------------------------------------------------------------------------------------------- 9 | WARNING | Line exceeds 80 characters; contains 200 characters 26 | WARNING | Line exceeds 80 characters; contains 86 characters 42 | WARNING | Line exceeds 80 characters; contains 133 characters 43 | WARNING | Line exceeds 80 characters; contains 146 characters 45 | WARNING | Line exceeds 80 characters; contains 90 characters 54 | WARNING | Line exceeds 80 characters; contains 82 characters 55 | WARNING | Line exceeds 80 characters; contains 86 characters 56 | WARNING | Line exceeds 80 characters; contains 93 characters 57 | WARNING | Line exceeds 80 characters; contains 102 characters 72 | WARNING | Line exceeds 80 characters; contains 307 characters 76 | WARNING | Line exceeds 80 characters; contains 355 characters 79 | WARNING | Line exceeds 80 characters; contains 397 characters 81 | WARNING | Line exceeds 80 characters; contains 107 characters 82 | WARNING | Line exceeds 80 characters; contains 189 characters 89 | WARNING | Line exceeds 80 characters; contains 173 characters 90 | WARNING | Line exceeds 80 characters; contains 123 characters 95 | WARNING | Line exceeds 80 characters; contains 133 characters 97 | WARNING | Line exceeds 80 characters; contains 308 characters 110 | WARNING | Line exceeds 80 characters; contains 101 characters -------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/docker-compose/README.md ----------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 102 characters ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/css/appsearch.css ---------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/tests/Controller/EngineControllerTest.php ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------- 47 | WARNING | Possible useless method overriding detected ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/templates/server.html.twig ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/templates/engine.html.twig ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/appsearch.theme.inc ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\Element. ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/search-ui/README.md ------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------ 25 | WARNING | Line exceeds 80 characters; contains 95 characters 36 | WARNING | Line exceeds 80 characters; contains 171 characters 38 | WARNING | Line exceeds 80 characters; contains 322 characters 40 | WARNING | Line exceeds 80 characters; contains 271 characters ------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/search-ui/build/static/css/main.css ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/search-ui/build/static/js/main.js.LICENSE.txt -------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | Line exceeds 80 characters; contains 148 characters -------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/search-ui/src/index.css ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 5 | ERROR | [ ] No style definition found on line; check for missing colon 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [ ] No style definition found on line; check for missing colon ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/ServerListBuilder.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\Entity\ServerInterface. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/EngineWipeAllConfirmForm.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Logger\LoggerChannelTrait. ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/EngineForm.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\AppSearchClientInterface. 38 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket 39 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 2 39 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 39 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/EngineSchema.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 51 | WARNING | Possible useless method overriding detected ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/FieldSchemaForm.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. 29 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 29 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/EngineStatusForm.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\Entity\EngineInterface. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Form/SyncEngineConfirmForm.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Entity/Engine.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\Utility\Database. -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Entity/Server.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\Entity\ConfigEntityBase. -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Plugin/Block/SearchUIBlock.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. 19 | ERROR | [ ] Class name doesn't match filename; expected "class SearchUIBlock" 51 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Tracker/TrackingManager.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 68 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Tracker/Tracker.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 62 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 434 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/AppSearchClient.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Elastic\EnterpriseSearch\AppSearch\Request\GetEngine. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Controller/EngineController.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\Entity\EngineInterface. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Controller/ServerController.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\appsearch\Entity\ServerInterface. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/EngineListBuilder.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Utility/Database.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\media\Entity\Media. ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/elastic_enterprise_search/modules/appsearch/src/Utility/BatchHelper.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 92 | ERROR | Public method name "BatchHelper::wipe_all" is not in lowerCamel format 99 | WARNING | Unused variable $page_count. -------------------------------------------------------------------------------------------------------------------------------------------- Time: 1.06 secs; Memory: 12MB ā contrib
Please check and advise.
Thank you. - š®š¹Italy apaderno Brescia, š®š¹
The issue summary still does not report which command has been used nor which arguments has been passed to that command.