- Issue created by @spokje
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,366 pass - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs review
over 1 year ago 12:26pm 28 April 2023 - last update
over 1 year ago 28,497 pass - Status changed to Needs work
over 1 year ago 2:05pm 28 April 2023 - Status changed to Needs review
over 1 year ago 2:13pm 28 April 2023 - 🇳🇱Netherlands spokje
Seems to have an issue for 10.1
Not really
- I accidentally tested the 10.0.x patch against 10.1.x: That didn't apply (of course)
- The "updated deps" run on 10.1.x still fails (although fails less), because of:(This is not the only reason, see 📌 Fix incorrect type hint and make daily "updated deps" QA jobs pass Fixed
- Status changed to RTBC
over 1 year ago 2:16pm 28 April 2023 - 🇮🇹Italy mondrake 🇮🇹
Why is there a baseline addition? Is that related to the introduction of the TrustedCallback attribute?
- 🇳🇱Netherlands spokje
Why is there a baseline addition? Is that related to the introduction of the TrustedCallback attribute?
Yep, looks like a regression.
Opened https://github.com/mglaman/phpstan-drupal/issues/543 - 🇬🇧United Kingdom catch
Should we wait for https://github.com/mglaman/phpstan-drupal/issues/543 or just update again when that's fixed?
- 🇳🇱Netherlands spokje
I would say: Update now, there are also more accessCheck issues with the new version, but haven't got around to admin/fix those.
-2/+1 in the baseline seems like a win :)
- last update
over 1 year ago 29,366 pass - Status changed to Needs work
over 1 year ago 9:32am 1 May 2023 - last update
over 1 year ago 29,367 pass - last update
over 1 year ago 29,367 pass - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 28,497 pass - Status changed to RTBC
over 1 year ago 9:59am 1 May 2023 - 🇳🇱Netherlands spokje
Unsure what needs re-rolling?
Both the 10.0.x and 10.1.x-patch still apply, back to RTBC.
- last update
over 1 year ago 29,367 pass - Status changed to Fixed
over 1 year ago 11:21am 1 May 2023 - 🇬🇧United Kingdom catch
Same confusions as #5, even though I'd already read it.
Committed/pushed the respective patches to 10.1.x and 10.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.