- Issue created by @spokje
- last update
over 1 year ago 28,497 pass - last update
over 1 year ago 29,300 pass - Status changed to Needs review
over 1 year ago 3:40pm 25 April 2023 - 🇳🇱Netherlands spokje
Technically there's no need to bump the version of
drupal/coder
in anycomposer
-file.
Unsure if we still want to do this in this issue. - last update
over 1 year ago 29,300 pass - Status changed to RTBC
over 1 year ago 4:13pm 25 April 2023 - 🇬🇧United Kingdom longwave UK
I don't see the need to bump Coder if we are going to fix the source of the issue instead. Added an updated deps test run to check that the fix works, assuming it does this is RTBC.
- last update
over 1 year ago 29,361 pass - Status changed to Needs work
over 1 year ago 2:13pm 28 April 2023 - 🇮🇹Italy mondrake 🇮🇹
Well, if that's a
const
, I guess it cannot be a@var
. Remove that annotation altogether? - Status changed to RTBC
over 1 year ago 2:18pm 28 April 2023 - 🇳🇱Netherlands spokje
@mondrake Per the official documentation it is allowed:
@var
You may use the @var tag to document the Type of the following Structural Elements:
Constants, both class and global scope
Properties
Variables, both global and local scopehttps://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/var.html
- 🇮🇹Italy mondrake 🇮🇹
I see... Never seen that used in Drupal tho. Drupal's coding standards → don't mention anything. But they're outdated, anyway, do not mention visibility either. So :shrug:
- 🇬🇧United Kingdom longwave UK
The constant could be refactored away,
::class
doesn't care if the class doesn't exist and it will evaluate to a string anyway, but that can be done in another issue: https://3v4l.org/0kGMp - last update
over 1 year ago 29,366 pass -
longwave →
committed 3a54df7a on 10.1.x
Issue #3356337 by Spokje, mondrake: Fix incorrect type hint and make...
-
longwave →
committed 3a54df7a on 10.1.x
-
longwave →
committed dcbf6ff0 on 10.0.x
Issue #3356337 by Spokje, mondrake: Fix incorrect type hint and make...
-
longwave →
committed dcbf6ff0 on 10.0.x
- Status changed to Fixed
over 1 year ago 9:28am 1 May 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed to 10.1.x and 10.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.