[2.0.x] Date All Day

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

I am assigning this issue.

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the user who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API. A project without code committed by the user who applies cannot be used for these applications, especially when the user doesn't have the permission to commit code.

1. Fix phpcs issue.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml date_all_day/

FILE: date_all_day/date_all_day.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 24 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

2. FILE: date_all_day.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

Thanks for your review. The requested changes have been fixed on the 2.0.x branch, could you review it again?

@akalam,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thank you so much :)

@vishal.kadam This issue was assigned to nielsaers because he should have done a review.

@apaderno Apologises. I didn’t see that it was assigned.

Picking this one up today.

Hey akalam,

1. date_all_day.js:
I think you might be attaching multiple change events to the same elements. Every time behaviors get triggered you'll add your change listener to existing and new items alike. If it is the case, use once and the context to apply your logic: https://www.drupal.org/docs/drupal-apis/javascript-api/javascript-api-ov... →

2. date_all_day.libraries.yml:
You define once as a dependency but you don't use it. See remark in 1.

The rest looks good! (Automated check didn't have any complaints other than the proposal to write some tests, but these aren't mandatory for this)

I am changing priority as per Issue priorities → .

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.