- Issue created by @hockey2112
- ๐บ๐ธUnited States hockey2112
Still hoping for this feature. Can this be added?
- ๐บ๐ธUnited States 3cwebdev
+1 for this request. It's standard feature for popups and user experience would expect the popup to be dismissed if the overlay area (outside of popup) is clicked or touched.
- ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Status changed to Needs review
11 months ago 11:42am 5 February 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
I have created MR !16 for solution of this issue.
- Status changed to Needs work
11 months ago 1:13pm 5 February 2024 - ๐บ๐ธUnited States SocialNicheGuru
Does not apply. I am on 3.1.0
- Installing drupal/simple_popup_blocks (3.1.0): Extracting archive
- Applying patches for drupal/simple_popup_blocks
https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... (Close popup when overlay area is clicked - https://www.drupal.org/project/simple_popup_blocks/issues/3356891 โจ Close popup when overlay area is clicked Needs review )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... - ๐ฎ๐ณIndia ravi kant Jaipur
@SocialNicheGuru
Thank you for reply.
You need to first apply the changes of below issue.
https://www.drupal.org/project/simple_popup_blocks/issues/3350919 ๐ Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBCThen apply my changes patch.
- ๐บ๐ธUnited States SocialNicheGuru
hmmm. it is not applying for me to spp 3.1.0. I tried teh MR and patch 25 from that issue
after patch 25
- Installing drupal/simple_popup_blocks (3.1.0): Extracting archive
- Applying patches for drupal/simple_popup_blocks
https://www.drupal.org/files/issues/2023-08-22/once_deprecation-3350919-... โ (Uncaught TypeError: $(...).once is not a function with Drupal 10 - https://www.drupal.org/project/simple_popup_blocks/issues/3350919 ๐ Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBC )
https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... (Must come after #3350919. Close popup when overlay area is clicked - https://www.drupal.org/project/simple_popup_blocks/issues/3356891 โจ Close popup when overlay area is clicked Needs review )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/...and after MR
- Installing drupal/simple_popup_blocks (3.1.0): Extracting archive
- Applying patches for drupal/simple_popup_blocks
https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... (Uncaught TypeError: $(...).once is not a function with Drupal 10 - https://www.drupal.org/project/simple_popup_blocks/issues/3350919 ๐ Uncaught TypeError: $(...).once is not a function with Drupal 10 RTBC )
https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/... (Must come after #3350919. Close popup when overlay area is clicked - https://www.drupal.org/project/simple_popup_blocks/issues/3356891 โจ Close popup when overlay area is clicked Needs review )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/...
- ๐ฎ๐ณIndia ravi kant Jaipur
How are you applying patch?
I am following asgit apply -v [patchname.patch]
And i am not getting any error. - ๐ฎ๐ณIndia ravi kant Jaipur
-
Download the patch from Merge Request page and apply
https://git.drupalcode.org/project/simple_popup_blocks/-/merge_requests/10 - Now download the patch same as above for my changes and apply.
-
Download the patch from Merge Request page and apply
- ๐ฎ๐ณIndia chandansha
fix the pop-up will close if you click on the overlay area.
- Status changed to Needs review
10 months ago 6:41am 20 February 2024 - Status changed to Needs work
10 months ago 11:28am 20 February 2024 - ๐บ๐ธUnited States SocialNicheGuru
The patch and the MR are quite different.
- ๐บ๐ฆUkraine vasyok
$("#" + spb_popup_id + " .block-olivero-content-modal").
i think it should be work not only in olivero theme - Status changed to Needs review
10 months ago 12:54pm 6 March 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@VasyOK
$(document).on('click', '.spb_overlay', function (e) { $('.' + modal_class).hide() startTheScroll() })
The jQuery is only targeting to overlay class which is providing by module.
So this is not according to specific theme. The provided patch(es) didn't work for us. Any interaction with a popup / modal resulted in the modal being closed.
Please note that the patch provided also includes Patch 3350919#25.Updated the patch file.
My installation order:
1. https://www.drupal.org/files/issues/2023-08-22/once_deprecation-3350919-... โ
2. https://www.drupal.org/files/issues/2024-02-20/3356891-14.patch โ
3. https://www.drupal.org/files/issues/2024-06-10/prevent_modal_interaction... โ