Fix the issues reported by phpcs

Open on Drupal.org →

Created on 25 April 2023, over 1 year ago

Updated 26 April 2023, over 1 year ago

FILE: /var/www/html/contribution/web/modules/contrib/poster_integration/poster_integration.module
--------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------
45 | ERROR | [x] Concat operator must be surrounded by a single space
46 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
54 | ERROR | [ ] Missing parameter type
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/poster_integration/poster_integration.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/poster_integration/

📌 Task

Status

Version

1.0

Component

Code

Created by

🇮🇳India himanshu_jhaloya Indore

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @himanshu_jhaloya
@himanshu_jhaloya opened merge request.
Issue was unassigned.
Status changed to Needs review over 1 year ago12:18pm 25 April 2023
Comment over 1 year ago →
🇮🇳India himanshu_jhaloya Indore
Status changed to RTBC over 1 year ago12:28pm 25 April 2023
Comment over 1 year ago →
🇵🇭Philippines clarkssquared
Hi himanshu_jhaloya

I applied your MR !1 in my local with Drupal 9.5.8 to "Poster POS Commerce Integration" against version 1.0.x-dev and confirmed that the PHPCS issues were fixed.

Please look at the screenshot attached for you reference.

Thank you.
Comment over 1 year ago →
🇮🇳India Jaspreet-Kaur
Verified MR !1 it worked for me. Thanks!
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work over 1 year ago6:34pm 26 April 2023

Comment over 1 year ago →

🇮🇹Italy apaderno Brescia, 🇮🇹

  * @param \Drupal\Core\Form\FormStateInterface $form_state
- *   Checkout Form state.
+ *   The current state of the checkout form.

The current state of the form. is sufficient.

First commit to issue fork.
Status changed to RTBC over 1 year ago8:10pm 26 April 2023
Comment over 1 year ago →
🇺🇦Ukraine akozoriz

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024