🇺🇦Ukraine @akozoriz

akozoriz → made their first commit to this issue’s fork.

Thank you, @sarwan_verma! Works as expected

Last release in Drupal 10 ready

akozoriz → created an issue.

akozoriz → created an issue.

akozoriz → made their first commit to this issue’s fork.

@bardiuk, Looks like your PHP version is 8.2.12, that does not satisfy the requirement
square/square 17.3.0.20220316 requires php >=7.2 <8.2

I already had required role and ready to maintain this module

In Drupal 9, 10 you can use this filter to add icons for file links in text.

File type indicator text filter →

akozoriz → made their first commit to this issue’s fork.

akozoriz → made their first commit to this issue’s fork.

@smustgrave It returns NULL because the author did the following steps:
1. Delete the sync/update.settings.yml
2. Import configurations (drush cim) (it will delete the database configurations)

That deletes 'update.settings' configuration from the active configuration. As a result, when we try to fetch 'update.settings' configuration to build UpdateSettingsForm, we will get NULL. If we properly handle this, we will build the config form and have the possibility save it and create a new 'update.settings' config.

@smustgrave For me, it's definitely what we should do - check if the value from the config is an array before sending it to the implode function. If config doesn't exist in our system - it returns NULL and generates an error when we put it to the implode.

akozoriz → made their first commit to this issue’s fork.

@cmlara thanks for the explanation. I was a bit confused, because I saw the list of possible licenses for Libs, but didn't notice that only about committing to the Drupal repo.
I returned the lib and validation.

@HitchShock thanks for your review.
All 2 points that you mentioned are fixed now.
1. giggsey/libphonenumber-for-php isn't used anymore.
2. Readme.md file is fixed.

akozoriz → made their first commit to this issue’s fork.

@sakonn ComgateRedirectController extends ControllerBase, which already has languageManager injected. Also, keep in mind, that the best practice in using DI for including any services to the controller.

@sakonn, pls update the dev version of the module, that you are using. I found one more issue, fixed in the last dev update.

@sakonn, great.
Would be great to get test links for additional testing.

@sakonn I merged your changes with some code style updated to the DEV branch. Please update your repository. Thanks for the work on the project!

@sakonn You are using outdated local branch, this fix already in DEV branch

akozoriz → made their first commit to this issue’s fork.

Thanks @apaderno!
I implemented your notices, and also refactored forms to decrease duplicate code.
Wait for your review.

@vishal.kadam Issues fixed.

@sakonn Changes look good to me, let me know if it works well on your store setup.
DEV version was updated.

@sakonn Thanks for the fix!

akozoriz → made their first commit to this issue’s fork.

@sahaj Sure, I will update and test the module for Drupal 10 during the next few days.

MR is created, which should fix the issue.
Also, I attached a patch if somebody needs it.

akozoriz → made their first commit to this issue’s fork.

Thanks, @Nor4a, looks good!

akozoriz → made their first commit to this issue’s fork.