- Issue created by @sakonn
- @sakonn opened merge request.
- Status changed to Needs review
over 1 year ago 9:45pm 4 March 2023 - πΊπ¦Ukraine akozoriz
@sakonn Changes look good to me, let me know if it works well on your store setup.
DEV version was updated. - @sakonn opened merge request.
- πΊπ¦Ukraine akozoriz
@sakonn You are using outdated local branch, this fix already in DEV branch
@akozoriz
Yes I have noticed that something is wrong. Sorry about that.
I have tried to update fork but have done something wrong. Where can I find some documentation how to do that properly?Here I have done simple patch file with additional changes that were necessary to implement for proper complete page redirections.
-
akozoriz β
committed c2085c4a on 1.0.x authored by
sakonn β
Issue #3345898 by sakonn: Allow module to choose currency and language
-
akozoriz β
committed c2085c4a on 1.0.x authored by
sakonn β
- πΊπ¦Ukraine akozoriz
@sakonn I merged your changes with some code style updated to the DEV branch. Please update your repository. Thanks for the work on the project!
I confirm that the development version of the module is working correctly. I can send you test environment links for multilanguage setup if you want to test it out.
- Status changed to RTBC
over 1 year ago 2:06pm 20 March 2023 - πΊπ¦Ukraine akozoriz
@sakonn, great.
Would be great to get test links for additional testing. Here you can check it out:
https://test.de.penguin.nosicetazne.sk/
https://test.hu.penguin.nosicetazne.sk/
https://test.sk.penguin.nosicetazne.sk/
https://test.cz.penguin.nosicetazne.sk/
https://test.en.penguin.nosicetazne.sk/Links are valid now during development period.
- πΊπ¦Ukraine akozoriz
@sakonn, pls update the dev version of the module, that you are using. I found one more issue, fixed in the last dev update.
I have checked the changes and I think it will be better to use global languageManager service since there is no such a service injected into the controller.
- πΊπ¦Ukraine akozoriz
@sakonn ComgateRedirectController extends ControllerBase, which already has languageManager injected. Also, keep in mind, that the best practice in using DI for including any services to the controller.