Fix the issues reported by phpcs (i18n_contact module)

Hi vimal_nadar,

I applied your patch #2, and I noticed that there is still phpcs errors and warnings being flagged in i18n_contact/i18n_contact.module,

FILE: /Users/studenttrainees/i18n/i18n_contact/i18n_contact.module
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
6 | ERROR | [x] Additional blank lines found at end of doc comment
65 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
65 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
75 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
81 | ERROR | [ ] The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Please look at the screenshot attached for your reference.

The above patch breaks PHP 5.3

Hi vimal_nadar,

I applied your patch #7, and I confirmed that the phpcs issues were fixed and resolved.

Please look at the screenshot attached for your reference

Thank you.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Updated issue summary.

-  if (in_array($message['id'], array('contact_page_mail', 'contact_page_copy', 'contact_page_autoreply'))) {
+  if (in_array($message['id'], array(
+    'contact_page_mail',
+    'contact_page_copy',
+    'contact_page_autoreply',
+  ))) {

That is code written as per PSR12 coding standards. Drupal coding standards say:

Control structure conditions may exceed 80 characters, if they are simple to read and understand.

In this case, the existing code is simpler to read and understand; the proposed change is not.

-      // Overwrite the whole message body. Maybe this is not entirely responsible
-      // (it might overwrite other existing items altered in by others),
-      // but unfortunately Drupal core cotact module does not make its item
-      // identifiable easily.
+      // Overwrite the whole message body. Maybe this is not entirely
+      // responsible (it might overwrite other existing items altered in by
+      // others), but unfortunately Drupal core cotact module does not make
+      // its item identifiable easily.

Since that comment is edited, there is a typo that should be fixed too: cotact is supposed to be Contact. (Yes, it is a capitalized word because that is the name of a module.)

Thanks @vimal_nadar, great work along with @apadermo, committed and credited.

Automatically closed - issue fixed for 2 weeks with no activity.