- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:01am 19 April 2023 - Status changed to Needs work
over 1 year ago 9:30am 19 April 2023 - 🇵🇭Philippines clarkssquared
I applied your patch #2 to the "Taxonomy Depth Widget" module against version 2.1.0. and confirmed that the mentioned phpcs errors were fixed, however, another new phpcs error was being flagged relating to taxonomy_depth_widget.info.yml.
Please look at the screenshot for your reference,
Thank you.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 7:59am 19 June 2023 - 🇮🇳India Ashutosh Ahirwal India
Hi @samit.310@gmail.com i have retested your patch with cloning the module from git clone command available on version control tab and it looks fine to me.
@clarkssquared I guess you have tested the patch after using the composer command to clone/download the module by using the composer command the "version, project, datestamp" get added by drupal in module info file.Moving to RTBC.
-
fabiansierra5191 →
committed 013b5413 on 2.x
Issue #3355066 by samit.310@gmail.com: Fix the issues reported by phpcs
-
fabiansierra5191 →
committed 013b5413 on 2.x
- Status changed to Fixed
over 1 year ago 10:37pm 30 June 2023 - 🇨🇴Colombia fabiansierra5191
Fixed on version 2.1.1, thanks for the patch and the tests!
- Status changed to Fixed
over 1 year ago 10:39pm 30 June 2023