- Issue created by @urvashi_vora
- ๐ต๐ญPhilippines kenyoOwen
Hi urvashi_vora
I applied patch coding-standard-fixes.patch โ to the โSimple account policyโ module and confirmed that the mentioned PHPCS issues are resolved except for the remaining task. Please see the screenshots attached.
For your review.
Thank you. - Assigned to imustakim
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- ๐จ๐ฆCanada imustakim Canada
~/Sites/Projects/simple_account_policy 3353911 โฏ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml . FILE: /Users/specbee/Sites/Projects/simple_account_policy/simple_account_policy.module -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------------- 245 | WARNING | Only string literals should be passed to t() where possible 292 | WARNING | Only string literals should be passed to t() where possible 342 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------------- Time: 646ms; Memory: 12MB
These 3 errors are remaining, because there are dynamic variables passing in t() function, assuming this can be ignored.
Other than this, all the errors are resolved.
Updated patch is attached. - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:33am 5 May 2023 - First commit to issue fork.
-
kriboogh โ
committed a3b62a65 on 1.0.x
Resolve #3353911 "Fix the issues"
-
kriboogh โ
committed a3b62a65 on 1.0.x
- Status changed to Fixed
10 months ago 2:07pm 3 June 2024 - ๐ง๐ชBelgium kriboogh
The 3 "Only string literals should be passed to t() where possible (Drupal.Semantics.FunctionT.NotLiteralString)" errors will remain, as we can't write that code in any other form.
- Status changed to Fixed
10 months ago 12:04pm 5 June 2024