Fix the issues reported by phpcs

Created on 13 April 2023, almost 2 years ago
Updated 5 June 2024, 10 months ago

GitLab Ci reports PHP_CodeSniffer warnings/errors which should be fixed. There are still warnings/errors to fix.

๐Ÿ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @urvashi_vora
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines kenyoOwen

    Hi urvashi_vora

    I applied patch coding-standard-fixes.patch โ†’ to the โ€œSimple account policyโ€ module and confirmed that the mentioned PHPCS issues are resolved except for the remaining task. Please see the screenshots attached.

    For your review.
    Thank you.

  • Assigned to imustakim
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada imustakim Canada

    Working on this.

  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • ๐Ÿ‡จ๐Ÿ‡ฆCanada imustakim Canada
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada imustakim Canada
    ~/Sites/Projects/simple_account_policy 3353911 
    โฏ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml .
    
    FILE: /Users/specbee/Sites/Projects/simple_account_policy/simple_account_policy.module
    --------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------------------
     245 | WARNING | Only string literals should be passed to t() where possible
     292 | WARNING | Only string literals should be passed to t() where possible
     342 | WARNING | Only string literals should be passed to t() where possible
    --------------------------------------------------------------------------------------
    
    Time: 646ms; Memory: 12MB
    

    These 3 errors are remaining, because there are dynamic variables passing in t() function, assuming this can be ignored.
    Other than this, all the errors are resolved.
    Updated patch is attached.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • ๐Ÿ‡จ๐Ÿ‡ฆCanada imustakim Canada
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • First commit to issue fork.
  • Merge request !9Resolve #3353911 "Fix the issues" โ†’ (Merged) created by kriboogh
  • ๐Ÿ‡ฎ๐Ÿ‡นItaly apaderno Brescia, ๐Ÿ‡ฎ๐Ÿ‡น
  • Pipeline finished with Success
    10 months ago
    Total: 189s
    #189850
  • Pipeline finished with Success
    10 months ago
    Total: 141s
    #189853
  • Pipeline finished with Canceled
    10 months ago
    #189921
  • Pipeline finished with Canceled
    10 months ago
    Total: 114s
    #189925
  • Pipeline finished with Success
    10 months ago
    Total: 220s
    #189927
  • Status changed to Fixed 10 months ago
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium kriboogh

    The 3 "Only string literals should be passed to t() where possible (Drupal.Semantics.FunctionT.NotLiteralString)" errors will remain, as we can't write that code in any other form.

  • Status changed to Fixed 10 months ago
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium kriboogh
Production build 0.71.5 2024