[8.x-1.x] Site Information Rest

@Pablo_Pukha Remember to change the status to Needs review when the project is ready for review.

@Pablo_Pukha Remember to change the status to Needs review when the project is ready for review.

1. 8.x-dev is a wrong branch name, as branch names end with the literal .x. That branch needs to be removed.

2. Remove the LICENSE.txt file. The LICENSE file isn't necessary. It will be added automatically by the packaging script.

3. Replace README.txt with README.md file. Follow the guidelines.

Thanks for your comments. I have successfully fixed the above issues

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

src/Plugin/rest/resource/SiteInfo.php

class SiteInfo extends ResourceBase {

  /**
   * The system.site config.
   *
   * @var \Drupal\Core\Config\ImmutableConfig
   */
  protected ImmutableConfig $siteConfig;

  /**
   * The request stack.
   *
   * @var \Symfony\Component\HttpFoundation\RequestStack
   */
  protected RequestStack $requestStack;

Drupal 9 minimum PHP version is PHP 7.3, which cannot parse those property definitions. Either those definitions are changed or the module requires at least Drupal 9.4, as per #2917655: [9.4.x only] Drop official PHP 7.3 support in Drupal 9.4 → .

  public function __construct(
    array $configuration,
    $plugin_id,
    $plugin_definition,
    array $serializer_formats,
    LoggerInterface $logger,
    ConfigFactoryInterface $config_factory,
    RequestStack $request_stack
  ) {

As per Drupal coding standards, all the method parameters must be defined on a single line. That is how code would be formatted as per PSR12, which is not a coding standards Drupal follows.

Thanks for your comments. I have successfully fixed the above issues

I have tested on local and found it is working fine. Code also looks good for me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Automatically closed - issue fixed for 2 weeks with no activity.