- Issue created by @Abhay Sharma
- Assigned to shivam_tiwari
- @shivam_tiwari opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:31am 26 April 2023 - @abhay-sharma opened merge request.
- 🇮🇳India Abhay Sharma
Hi shivam_tiwari,
I have removed the core: 8.x from the info.yml file which core:8.x is not required in Drupal 10
added core version requirement: in the info.yml file on 3353366-automated-drupal-10 branchI have installed the module in Drupal 10 now it looks compatible with Drupal 10 but I can't see the close button output in the Drupal block.
- Status changed to Active
over 1 year ago 10:17am 22 May 2023 - 🇨🇦Canada joseph.olstad
The automated D10 changes didn't come in because the default branch is "master" and the "master" branch doesn't contain a fymfony based Drupal module.
see 🌱 Change the default branch of closeblock to 8.x-1.x Needs work - 🇨🇦Canada joseph.olstad
drush upgrade_status:analyze closeblock [notice] Processing /home/ide/project/docroot/modules/contrib/closeblock. ================================================================================ Close block, 8.x-1.0 Scanned on ven 02/06/2023 - 17:55 FILE: modules/contrib/closeblock/closeblock.libraries.yml STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 The 'closeblock' library is depending on a deprecated library. The core/jquery.cookie asset library is deprecated in Drupal 9.0.0 and will be removed in Drupal 10.0.0. Use the core/js-cookie library instead. See https://www.drupal.org/node/3104677 -------------------------------------------------------------------------------- Check manually 0 The 'closeblock' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256 -------------------------------------------------------------------------------- FILE: modules/contrib/closeblock/closeblock.info.yml STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 0 Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687. --------------------------------------------------------------------------------
- 🇺🇸United States srdtwc Skokie, IL
For anyone looking for a similar module that is D10 compatible check out https://www.drupal.org/project/collapsiblock →
- Assigned to sahilgidwani
- 🇮🇳India sahilgidwani Jaipur
We need to remove the core key also in info.yml, removed the core key and update the patch.
- Status changed to Needs review
about 1 year ago 6:26am 21 September 2023 - 🇨🇦Canada joseph.olstad
note, if you upgrade to the D10 compatible version of radix, you may end up missing a block id which wil prevent this module from doing what it is supposed to do.
🐛 Block id is removed in the block component Needs work
there's a patch I'm using there.With that said, the patches above aren't working.
once doesn't behave the same as jquery once. Cookie and strict mode may be interefering also. - 🇨🇦Canada joseph.olstad
Ok patch 17, I will test this again ASAP
If this passes manual tests I will cut a release