Use httpMethod instead of type for AJAX get/post request property

+1. Way more intuitive.

Untested patch. Couple of things I noticed:

- type was probably originally chosen because jQuery.ajax used 'type' for GET/POST.

- Since jQuery 1.9, it allows method, which type is a direct alias/bc for, although ajax.js relies on 'type' still, likely just because it's never been updated.

- as lauriii points out in the other issue, we can't use 'method' because we already use that for replacements.

So... trying httpMethod, I changed the one reference to jQuery AJAX 'type' to 'method' too here since that makes things slightly more consistent.

Passed through my mind that we should consider renaming 'method' to 'replaceMethod' in the AJAX API too, different issue if we wanted to do that though.

Throwing my hat into the bikeshed: these are commonly referred to as HTTP verbs, so if we can't use method what about verb?

> so if we can't use method what about verb?
Good point. I would've had to scratch my head what this means though. So while technically more correct, maybe not so intuitive for some.

Also, i'd prefer httpMethod over method (and verb), because it includes the context, so its meaning is not dependent on additional context.

+1 for httpMethod over verb. I appreciate the verbosity

“HTTP method” is more explicit than “method” or “verb” to my ears too.

Plus, it’s consistent with how Symfony refers to it in its route definitions.

If I got a vote I like httpMethod.

+++ b/core/misc/ajax.js
@@ -325,12 +325,12 @@
+      const httpMethod = $linkElement.data('ajax-httpMethod');

As a data attribute wouldn't this become data-http-method? Data attribute usually use kebab-case instead of snakeCase.

I also don't see any test coverage for this :(

Just to keep it moving, sending to NW for test coverage.

I don't think we should add test coverage for a direct rename, there is a lot of implicit coverage of the AJAX API via views but not much explicit. Leaving needs work for #9 though.

Addressed the feedback and updated the comments.

+++ b/core/misc/ajax.js
@@ -325,12 +325,12 @@
        * In case of setting custom ajax type for link we rewrite ajax.type.

I think this comment needs updating a bit given one part of it is no longer called "type". This comment didn't really add much anyway, not sure it is needed, although it is perhaps the only documentation for this feature.

I am still concerned there is no test coverage for data-ajax-type / data-ajax-http-method but I suppose that shouldn't hold this up otherwise we have to do a deprecation dance and so that can be deferred to a followup.

This should address #13.

Opened 📌 Add test coverage for data-ajax-http-method attribute Active as a follow up.

Committing this now so it can get in before the alpha release.

Committed and pushed cb77884135 to 10.1.x. Thanks!

Will update the change record to mention the new property name.

Updated https://www.drupal.org/node/3193798 → and linked it to this issue.

Automatically closed - issue fixed for 2 weeks with no activity.