Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 7 April 2023, almost 2 years ago
Updated 10 July 2023, over 1 year ago

Problem/Motivation

Getting following error/warnings.
FILE: /web/modules/contrib/views_infinite_scroll/views_infinite_scroll.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
57 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/views_infinite_scroll/README.txt
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 97 characters
19 | WARNING | Line exceeds 80 characters; contains 134 characters
31 | WARNING | Line exceeds 80 characters; contains 168 characters
----------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/views_infinite_scroll/src/EventSubscriber/AjaxResponseSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
41 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 724ms; Memory: 12MB

Steps to reproduce

Run following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/views_infinite_scroll/

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

mukesh88

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @mukesh88
  • Comment almost 2 years ago →
    mukesh88
  • Issue was unassigned.
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇵🇭Philippines kenyoOwen

    Hi mukesh88

    I applied the patch to the “Vies Infinite Scroll” module against Version 2.0.x-dev and confirmed that the error and warnings are resolved. Please see the screenshots attached.

    For your review.
    Thank you.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
    -* For a full description of the module visit https://www.drupal.org/project/views_infinite_scroll
+* For a full description of the module visit
+ https://www.drupal.org/project/views_infinite_scroll

    Since that is part of a list, the last line must be indented.

    -* To submit bug reports and feature suggestions, or to track changes visit https://www.drupal.org/project/issues/views_infinite_scroll
+* To submit bug reports and feature suggestions, or to track changes visit
+ https://www.drupal.org/project/issues/views_infinite_scroll

    Ditto.

    -* Install the Views Infinite Scroll module as you would normally install a contributed Drupal module. Visit https://www.drupal.org/node/1897420 for further information.
+* Install the Views Infinite Scroll module as you would normally install
+ a contributed Drupal module. Visit https://www.drupal.org/node/1897420
+ for further information.

    The same holds true here, for the last two lines.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.3 & MySQL 8
    last update over 1 year ago
    Composer error. Unable to continue.
  • @bharath-kondeti opened merge request.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India bharath-kondeti Hyderabad

    Addressed review comments and opened an MR.

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    LGTM!

  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    The Composer error reported for the MR is because tests use PHP 7.3 and Drupal 10 when Drupal 10 requires PHP 8.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    1 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.3 & MySQL 8
    last update over 1 year ago
    Composer error. Unable to continue.
  • Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.3 & MySQL 8
    last update over 1 year ago
    Not currently mergeable.
  • @anybody opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 7.3 & MySQL 8
    last update over 1 year ago
    Composer error. Unable to continue.
  • Comment over 1 year ago →
    System Message
  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica
  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024