- Issue created by @sleitner
- Status changed to Needs review
almost 2 years ago 10:09pm 5 April 2023 - Status changed to RTBC
almost 2 years ago 3:09pm 6 April 2023 - πΊπΈUnited States smustgrave
Change looks good. Maybe could be a task but will leave as bug.
- Status changed to Needs review
almost 2 years ago 9:59pm 10 April 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
+++ b/core/modules/language/tests/src/Functional/LanguageNegotiationSessionTest.php @@ -51,24 +46,15 @@ protected function setUp(): void { - $config->set('negotiation.language_interface.method_weights', [ - 'language-user-admin' => -10, - LanguageNegotiationUrl::METHOD_ID => -8, - LanguageNegotiationSession::METHOD_ID => -6, - 'language-user' => -4, - LanguageNegotiationBrowser::METHOD_ID => -2, - LanguageNegotiationSelected::METHOD_ID => 12, - ]); - $config->save(); + $this->drupalGet('admin/config/regional/language/detection'); + $edit = [ + 'language_interface[enabled][language-session]' => 1, + 'language_interface[enabled][language-selected]' => 1, + 'language_interface[weight][language-session]' => -6, + 'language_interface[weight][language-selected]' => 12,
can you elaborate why we're only setting some of the values now?
- π©πͺGermany sleitner
@larowlan I added only these which change, not the unchanged.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
@sleitner ah, thanks, feel free to re-rtbc then
- Status changed to RTBC
almost 2 years ago 11:08am 12 April 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Queued tests on 10.0.x and 9.5.x
Committed to 10.1.x
-
larowlan β
committed af1eb719 on 10.1.x
Issue #3352524 by sleitner: Do not use direct configuration changes in...
-
larowlan β
committed af1eb719 on 10.1.x
-
larowlan β
committed 67281b6c on 10.0.x
Issue #3352524 by sleitner: Do not use direct configuration changes in...
-
larowlan β
committed 67281b6c on 10.0.x
-
larowlan β
committed 5e5a695c on 9.5.x
Issue #3352524 by sleitner: Do not use direct configuration changes in...
-
larowlan β
committed 5e5a695c on 9.5.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Backported to 10.0.x and 9.5.x for consistency
- Status changed to Fixed
over 1 year ago 10:29pm 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.