- Issue created by @Anybody
- Assigned to Binoli Lalani
- @binoli-lalani opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:09am 6 April 2023 - 🇮🇳India Binoli Lalani Gujarat
Hello,
I removed duplicate email domains before saving the configuration form. I fixed it in MR. Please review.
Thank you!
- 🇩🇪Germany Anybody Porta Westfalica
Thank you @Binoli Lalani that looks quite well already.
I'm unsure, if it wouldn't perhaps make sense to use this change to no more store the patterns as string with linebreaks like in the form, but instead as array of strings and re-transform for the array...
That would clean things up a bit, I guess. But a maintainer should decide.
I'm talking about this area: https://git.drupalcode.org/issue/domain_registration-3352421/-/blob/8.x-...If you'd like to implement that change (incl. an update hook) I'ld suggest doing it in a separate MR so the maintainer can decide.
Let's for now leave this "Needs review".
- Status changed to Needs work
over 1 year ago 8:53am 24 April 2023 - 🇪🇸Spain pcambra Asturies
I'm not sure we want to change this here, the only thing this MR should do is to clean duplicated patterns (as I understand the issue), right?
Setting to NW.
- 🇩🇪Germany Anybody Porta Westfalica
- 🇪🇸Spain pcambra Asturies
I think preprocess on save and store the sanitized value makes a lot of sense :)