- Issue created by @urvashi_vora
- 🇵ðŸ‡Philippines paraderojether
Hi urvashi_vora
I reviewed patch coding-standard-fixes.patch, and there are still remaining errors and warning shown below:
FILE: ...udenttrainees/New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/sales_zymphonies_theme.theme
----------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------
123 | ERROR | Doc comment short description must be on a single line, further text should be a separate
| | paragraph
256 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
256 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
263 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
263 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
270 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
270 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
276 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
276 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
282 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
282 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
----------------------------------------------------------------------------------------------------------------FILE: .../New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/includes/fontawesome/css/font-awesome.css
----------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------
121 | ERROR | Style definitions must end with a semicolon
127 | ERROR | Style definitions must end with a semicolon
133 | ERROR | Style definitions must end with a semicolon
139 | ERROR | Style definitions must end with a semicolon
145 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------Time: 923ms; Memory: 20MB
Please check.
Thank You. - 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @paraderojether,
Yes, I have added them in Remaining tasks.
- Status changed to Needs review
about 1 year ago 11:24am 3 May 2023