Fix the issues reported by PHPCS

Created on 4 April 2023, about 1 year ago
Updated 3 May 2023, about 1 year ago

Problem/Motivation

Fix the issues reported by PHPCS for Drupal and DrupalPractice standards in branch 2.0.x

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig sales_zymphonies_theme/

Proposed resolution

Fix all the issues listed after executing the command

Remaining tasks

Fixed few issues, the remaining issues are listed below:

FILE: ...s/contrib/sales_zymphonies_theme/includes/fontawesome/css/font-awesome.css
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
121 | ERROR | Style definitions must end with a semicolon
127 | ERROR | Style definitions must end with a semicolon
133 | ERROR | Style definitions must end with a semicolon
139 | ERROR | Style definitions must end with a semicolon
145 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------

FILE: ...ontrib/sales_zymphonies_theme/includes/smartmenus/jquery.smartmenus.min.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...ules/contrib/sales_zymphonies_theme/includes/bootstrap/js/bootstrap.min.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...es/contrib/sales_zymphonies_theme/includes/bootstrap/css/bootstrap.min.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...trib/sales_zymphonies_theme/includes/bootstrap/css/bootstrap-theme.min.css
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...rib/sales_zymphonies_theme/includes/flexslider/js/jquery.flexslider-min.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...l8/web/modules/contrib/sales_zymphonies_theme/sales_zymphonies_theme.theme
--------------------------------------------------------------------------------
FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
123 | ERROR | Doc comment short description must be on a single line,
| | further text should be a separate paragraph
256 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
256 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
263 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
263 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
270 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
270 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
276 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
276 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
282 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
282 | ERROR | Concatenating translatable strings is not allowed, use
| | placeholders instead and only one string literal
--------------------------------------------------------------------------------

Time: 2.15 secs; Memory: 28MB

Please review the patch for fixing few errors and warnings.

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • 🇵🇭Philippines paraderojether

    Hi urvashi_vora

    I reviewed patch coding-standard-fixes.patch, and there are still remaining errors and warning shown below:

    FILE: ...udenttrainees/New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/sales_zymphonies_theme.theme
    ----------------------------------------------------------------------------------------------------------------
    FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 6 LINES
    ----------------------------------------------------------------------------------------------------------------
    123 | ERROR | Doc comment short description must be on a single line, further text should be a separate
    | | paragraph
    256 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
    | | variables
    256 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
    | | string literal
    263 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
    | | variables
    263 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
    | | string literal
    270 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
    | | variables
    270 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
    | | string literal
    276 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
    | | variables
    276 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
    | | string literal
    282 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
    | | variables
    282 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
    | | string literal
    ----------------------------------------------------------------------------------------------------------------

    FILE: .../New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/includes/fontawesome/css/font-awesome.css
    ----------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ----------------------------------------------------------------------------------------------------------------
    121 | ERROR | Style definitions must end with a semicolon
    127 | ERROR | Style definitions must end with a semicolon
    133 | ERROR | Style definitions must end with a semicolon
    139 | ERROR | Style definitions must end with a semicolon
    145 | ERROR | Style definitions must end with a semicolon
    ----------------------------------------------------------------------------------------------------------------

    Time: 923ms; Memory: 20MB

    Please check.
    Thank You.

  • 🇮🇳India urvashi_vora Madhya Pradesh, India

    Hi @paraderojether,

    Yes, I have added them in Remaining tasks.

  • Status changed to Needs review about 1 year ago
  • 🇮🇳India sakthi_dev

    Created a patch. Please review,

Production build 0.69.0 2024