Fix the issues reported by PHPCS

Hi urvashi_vora

I reviewed patch coding-standard-fixes.patch, and there are still remaining errors and warning shown below:

FILE: ...udenttrainees/New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/sales_zymphonies_theme.theme
----------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 5 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------
123 | ERROR | Doc comment short description must be on a single line, further text should be a separate
| | paragraph
256 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
256 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
263 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
263 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
270 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
270 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
276 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
276 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
282 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for
| | variables
282 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one
| | string literal
----------------------------------------------------------------------------------------------------------------

FILE: .../New/drupalorgsite/docroot/themes/contrib/sales_zymphonies_theme/includes/fontawesome/css/font-awesome.css
----------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------
121 | ERROR | Style definitions must end with a semicolon
127 | ERROR | Style definitions must end with a semicolon
133 | ERROR | Style definitions must end with a semicolon
139 | ERROR | Style definitions must end with a semicolon
145 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------

Time: 923ms; Memory: 20MB

Please check.
Thank You.

Hi @paraderojether,

Yes, I have added them in Remaining tasks.

Created a patch. Please review,

Hi

I applied the patch #4 and I confirmed that it fixes the PHPCS issues,

➜  sales_zymphonies_theme git:(8.x-1.x) curl https://www.drupal.org/files/issues/2023-05-03/phpcs-issue-3352125-4.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  118k  100  118k    0     0   216k      0 --:--:-- --:--:-- --:--:--  224k
patching file 'config/install/sales_zymphonies_theme.settings.yml'
patching file 'config/optional/block.block.sales_zymphonies_theme_page_title.yml'
patching file 'css/global.css'
patching file 'css/media.css'
patching file 'includes/bootstrap/js/bootstrap.js'
patching file 'includes/fontawesome/css/font-awesome.css'
patching file 'includes/smartmenus/sm-core-css.css'
patching file 'js/custom.js'
patching file sales_zymphonies_theme.info.yml
patching file sales_zymphonies_theme.libraries.yml
patching file sales_zymphonies_theme.theme
➜  sales_zymphonies_theme git:(8.x-1.x) ✗ ..
➜  drupal_local git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sales_zymphonies_theme

FILE: ...ts/d10/drupal_local/sales_zymphonies_theme/sales_zymphonies_theme.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 904ms; Memory: 20MB

➜  drupal_local git:(main) ✗