Fix the issues reported by phpcs

Open on Drupal.org →

Created on 3 April 2023, over 1 year ago

Updated 22 May 2023, about 1 year ago

Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/content_remote_options/tests/modules/content_remote_options_test/content_remote_options_test.routing.yml
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/content_remote_options/src/Plugin/Field/FieldWidget/ListRemoteOptionsSelectWidget.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/content_remote_options/src/Plugin/Field/FieldType/ListRemoteOptionsItem.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
229 | WARNING | Unused variable $k.
---------------------------------------------------------------------------------------------------------------

Time: 2.09 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/content_remote_options/

Proposed resolution

Above error/warnings need to be fixed.

📌 Task

Status

Fixed

Version

1.1

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @samit.310@gmail.com
Issue was unassigned.
Status changed to Needs review over 1 year ago7:36am 3 April 2023
Comment over 1 year ago →
🇮🇳India samit.310@gmail.com
Above errors/warnings has been fixed.
Status changed to RTBC over 1 year ago8:01am 3 April 2023
Comment over 1 year ago →
🇮🇳India Ashutosh Ahirwal India
Patch get applied cleanly.
Status changed to Needs work over 1 year ago8:55am 3 April 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The patch could apply, but it is not correct.

requirements: + # For testing only, can be open
Comments are sentences, which means they end with a period.
That comment can be better written, for example Since this is a test route, it does not require a specific permission to be accessed.
I would rather ignore the report, since that is a route defined in a test module, which by definition is not accessed outside tests.
Comment about 1 year ago →
🇵🇹Portugal TiagoZ
Thanks for the contribution. The patch was committed and it's already available on the last release 1.1.2.
Status changed to Fixed about 1 year ago11:37am 22 May 2023
Comment about 1 year ago →
🇵🇹Portugal TiagoZ
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024