- Issue created by @longwave
- Status changed to Needs review
over 1 year ago 1:27pm 31 March 2023 - π¬π§United Kingdom longwave UK
I kept PHPUnit on 9.5 as π Update to PHPUnit 9.6.7 Fixed will solve this separately.
egulias/email-validator
has a major version bump, will open a separate issue to deal with that.+------------------------------------+--------+--------+ | Production Changes | From | To | +------------------------------------+--------+--------+ | guzzlehttp/psr7 | 2.4.3 | 2.4.4 | | symfony/console | v6.2.5 | v6.2.8 | | symfony/dependency-injection | v6.2.6 | v6.2.8 | | symfony/deprecation-contracts | v3.2.0 | v3.2.1 | | symfony/error-handler | v6.2.5 | v6.2.7 | | symfony/event-dispatcher | v6.2.5 | v6.2.8 | | symfony/event-dispatcher-contracts | v3.2.0 | v3.2.1 | | symfony/http-foundation | v6.2.6 | v6.2.8 | | symfony/http-kernel | v6.2.6 | v6.2.8 | | symfony/mime | v6.2.5 | v6.2.7 | | symfony/process | v6.2.5 | v6.2.8 | | symfony/routing | v6.2.5 | v6.2.8 | | symfony/serializer | v6.2.5 | v6.2.8 | | symfony/service-contracts | v3.2.0 | v3.2.1 | | symfony/string | v6.2.5 | v6.2.8 | | symfony/translation-contracts | v3.2.0 | v3.2.1 | | symfony/validator | v6.2.5 | v6.2.8 | | symfony/var-dumper | v6.2.5 | v6.2.8 | | symfony/var-exporter | v6.2.5 | v6.2.8 | | symfony/yaml | v6.2.5 | v6.2.7 | +------------------------------------+--------+--------+ +------------------------------------+----------+----------+ | Dev Changes | From | To | +------------------------------------+----------+----------+ | composer/composer | 2.5.4 | 2.5.5 | | myclabs/deep-copy | 1.11.0 | 1.11.1 | | nikic/php-parser | v4.15.3 | v4.15.4 | | phpdocumentor/type-resolver | 1.6.2 | 1.7.1 | | phpstan/phpdoc-parser | 1.15.3 | 1.16.1 | | phpstan/phpstan | 1.10.2 | 1.10.9 | | phpunit/php-code-coverage | 9.2.24 | 9.2.26 | | sirbrillig/phpcs-variable-analysis | v2.11.10 | v2.11.14 | | slevomat/coding-standard | 8.8.0 | 8.9.1 | | symfony/browser-kit | v6.2.5 | v6.2.7 | | symfony/css-selector | v6.2.5 | v6.2.7 | | symfony/dom-crawler | v6.2.5 | v6.2.8 | | symfony/filesystem | v6.2.5 | v6.2.7 | | symfony/finder | v6.2.5 | v6.2.7 | | symfony/lock | v6.2.5 | v6.2.8 | | symfony/phpunit-bridge | v6.2.5 | v6.2.7 | +------------------------------------+----------+----------+
The last submitted patch, 2: 3351556-2.patch, failed testing. View results β
- π¬π§United Kingdom longwave UK
Add
@return void
toContainer::reset()
which skips the deprecation notice, this should be OK until Symfony 7. - π¬π§United Kingdom longwave UK
So, coding standards unexpectedly got in the way:
203 | ERROR | If there is no return value for a function, there must | | not be a @return tag. | | (Drupal.Commenting.FunctionComment.VoidReturn)
@return void
means there is no return statement, so Coder is kinda wrong here. But if we can't silence Symfony's deprecation the recommended way, we will have to add a deprecation skip for it I think. - Status changed to RTBC
over 1 year ago 8:28pm 31 March 2023 - πΊπΈUnited States smustgrave
All green now. Tons of update tickets today!
- π³π±Netherlands spokje
Do we want to add
diff --git a/core/.deprecation-ignore.txt b/core/.deprecation-ignore.txt index eee2e0db23..ea8370ee74 100644 --- a/core/.deprecation-ignore.txt +++ b/core/.deprecation-ignore.txt @@ -27,3 +27,6 @@ %Drupal\\media\\Form\\EditorMediaDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493% %Drupal\\editor\\Form\\EditorImageDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493% %Drupal\\editor\\Form\\EditorLinkDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493% + +# Symfony 7. +%Method "Symfony\\Contracts\\Service\\ResetInterface::reset\(\)" might add "void" as a native return type declaration in the future. Do the same in implementation "Drupal\\Component\\DependencyInjection\\Container" now to avoid errors or add an explicit @return
to
10.0.x
as well to make it pass the dailyupdated deps
-test run that has been failing since March 1st?
https://www.drupal.org/pift-ci-job/2632360 β The last submitted patch, 5: 3351556-5.patch, failed testing. View results β
- π¬π§United Kingdom longwave UK
Random fail in LayoutBuilderUiTest - back to RTBC.
- Status changed to Downport
over 1 year ago 10:41am 5 April 2023 - Assigned to spokje
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:48am 5 April 2023 The last submitted patch, 14: 3351556-10.0.x-14.patch, failed testing. View results β
- Status changed to Needs work
over 1 year ago 11:18am 5 April 2023 - Status changed to Needs review
over 1 year ago 11:19am 5 April 2023 - Status changed to RTBC
over 1 year ago 11:47am 5 April 2023 - π¬π§United Kingdom catch
Good plan with the issue title. Pre-emptively marking RTBC, if this comes back green from the bot I'll commit it.
-
longwave β
committed 46a420b3 on 10.0.x
Issue #3351556 by longwave, Spokje, catch: Add deprecation silencer on...
-
longwave β
committed 46a420b3 on 10.0.x
- π¬π§United Kingdom longwave UK
Committed the deprecation silencer to 10.0.x.
- Status changed to Fixed
over 1 year ago 5:29pm 20 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.