Update dependencies for Drupal 10.1/Add deprecation silencer on Drupal 10.0

Created on 31 March 2023, about 1 year ago
Updated 20 April 2023, about 1 year ago

Problem/Motivation

The "updated deps" test is failing, so let's update deps here and see what we need to fix before Drupal 10.1.0-alpha1.

Steps to reproduce

Proposed resolution

composer update

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.0 ✨

Component
ComposerΒ  β†’

Last updated about 23 hours ago

No maintainer
Created by

πŸ‡¬πŸ‡§United Kingdom longwave UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @longwave
  • Status changed to Needs review about 1 year ago
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    I kept PHPUnit on 9.5 as πŸ“Œ Update to PHPUnit 9.6.7 Fixed will solve this separately.

    egulias/email-validator has a major version bump, will open a separate issue to deal with that.

    +------------------------------------+--------+--------+
    | Production Changes                 | From   | To     |
    +------------------------------------+--------+--------+
    | guzzlehttp/psr7                    | 2.4.3  | 2.4.4  |
    | symfony/console                    | v6.2.5 | v6.2.8 |
    | symfony/dependency-injection       | v6.2.6 | v6.2.8 |
    | symfony/deprecation-contracts      | v3.2.0 | v3.2.1 |
    | symfony/error-handler              | v6.2.5 | v6.2.7 |
    | symfony/event-dispatcher           | v6.2.5 | v6.2.8 |
    | symfony/event-dispatcher-contracts | v3.2.0 | v3.2.1 |
    | symfony/http-foundation            | v6.2.6 | v6.2.8 |
    | symfony/http-kernel                | v6.2.6 | v6.2.8 |
    | symfony/mime                       | v6.2.5 | v6.2.7 |
    | symfony/process                    | v6.2.5 | v6.2.8 |
    | symfony/routing                    | v6.2.5 | v6.2.8 |
    | symfony/serializer                 | v6.2.5 | v6.2.8 |
    | symfony/service-contracts          | v3.2.0 | v3.2.1 |
    | symfony/string                     | v6.2.5 | v6.2.8 |
    | symfony/translation-contracts      | v3.2.0 | v3.2.1 |
    | symfony/validator                  | v6.2.5 | v6.2.8 |
    | symfony/var-dumper                 | v6.2.5 | v6.2.8 |
    | symfony/var-exporter               | v6.2.5 | v6.2.8 |
    | symfony/yaml                       | v6.2.5 | v6.2.7 |
    +------------------------------------+--------+--------+
    
    +------------------------------------+----------+----------+
    | Dev Changes                        | From     | To       |
    +------------------------------------+----------+----------+
    | composer/composer                  | 2.5.4    | 2.5.5    |
    | myclabs/deep-copy                  | 1.11.0   | 1.11.1   |
    | nikic/php-parser                   | v4.15.3  | v4.15.4  |
    | phpdocumentor/type-resolver        | 1.6.2    | 1.7.1    |
    | phpstan/phpdoc-parser              | 1.15.3   | 1.16.1   |
    | phpstan/phpstan                    | 1.10.2   | 1.10.9   |
    | phpunit/php-code-coverage          | 9.2.24   | 9.2.26   |
    | sirbrillig/phpcs-variable-analysis | v2.11.10 | v2.11.14 |
    | slevomat/coding-standard           | 8.8.0    | 8.9.1    |
    | symfony/browser-kit                | v6.2.5   | v6.2.7   |
    | symfony/css-selector               | v6.2.5   | v6.2.7   |
    | symfony/dom-crawler                | v6.2.5   | v6.2.8   |
    | symfony/filesystem                 | v6.2.5   | v6.2.7   |
    | symfony/finder                     | v6.2.5   | v6.2.7   |
    | symfony/lock                       | v6.2.5   | v6.2.8   |
    | symfony/phpunit-bridge             | v6.2.5   | v6.2.7   |
    +------------------------------------+----------+----------+
    
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Add @return void to Container::reset() which skips the deprecation notice, this should be OK until Symfony 7.

  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    So, coding standards unexpectedly got in the way:

     203 | ERROR | If there is no return value for a function, there must
         |       | not be a @return tag.
         |       | (Drupal.Commenting.FunctionComment.VoidReturn)
    

    @return void means there is no return statement, so Coder is kinda wrong here. But if we can't silence Symfony's deprecation the recommended way, we will have to add a deprecation skip for it I think.

  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    All green now. Tons of update tickets today!

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    Adding to parent

  • πŸ‡³πŸ‡±Netherlands Spokje

    Do we want to add

    diff --git a/core/.deprecation-ignore.txt b/core/.deprecation-ignore.txt
    index eee2e0db23..ea8370ee74 100644
    --- a/core/.deprecation-ignore.txt
    +++ b/core/.deprecation-ignore.txt
    @@ -27,3 +27,6 @@
     %Drupal\\media\\Form\\EditorMediaDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493%
     %Drupal\\editor\\Form\\EditorImageDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493%
     %Drupal\\editor\\Form\\EditorLinkDialog is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/project/drupal/issues/3291493%
    +
    +# Symfony 7.
    +%Method "Symfony\\Contracts\\Service\\ResetInterface::reset\(\)" might add "void" as a native return type declaration in the future. Do the same in implementation "Drupal\\Component\\DependencyInjection\\Container" now to avoid errors or add an explicit @return 
    

    to 10.0.x as well to make it pass the daily updated deps-test run that has been failing since March 1st?
    https://www.drupal.org/pift-ci-job/2632360 β†’

  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Random fail in LayoutBuilderUiTest - back to RTBC.

    • catch β†’ committed 5f167385 on 10.1.x
      Issue #3351556 by longwave: Update dependencies for Drupal 10.1
      
  • Status changed to Downport about 1 year ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Committed 5f16738 and pushed to 10.1.x. Thanks!

    Moving back to 10.0.x for #7 which seems like a good idea to me - we should change the commit message though so it's not confusing.

  • Assigned to Spokje
  • πŸ‡³πŸ‡±Netherlands Spokje
  • Issue was unassigned.
  • Status changed to Needs review about 1 year ago
  • πŸ‡³πŸ‡±Netherlands Spokje
  • Status changed to Needs work about 1 year ago
  • πŸ‡³πŸ‡±Netherlands Spokje
  • Status changed to Needs review about 1 year ago
  • πŸ‡³πŸ‡±Netherlands Spokje
  • Status changed to RTBC about 1 year ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Good plan with the issue title. Pre-emptively marking RTBC, if this comes back green from the bot I'll commit it.

    • longwave β†’ committed 46a420b3 on 10.0.x
      Issue #3351556 by longwave, Spokje, catch: Add deprecation silencer on...
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Committed the deprecation silencer to 10.0.x.

  • Status changed to Fixed about 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024