Update to PHPUnit 9.6.7

FTR, I'm not sure what is the eventual situation for this: https://github.com/sebastianbergmann/phpunit/issues/4775.

Need to check if there are remaining setMethods() calls in core, I'm not sure an automated deprecation error is fired here.

The last submitted patch, 3: 3338907-3.patch, failed testing. View results →

Working on this.

Converted PHPUnit warnings to deprecations and ignored them.

This is critical because our ::upgradePHPUnit script is failing on 9.5.x as it installs 9.6

See https://www.drupal.org/pift-ci-job/2585008 →

Although, we may choose to open a separate issue to prevent the composer script going all the way to 9.6 to avoid needing to make changes to 9.4/9.5

Changing the status to needs work for the requested comment on the DiffOpTest

I've created 🐛 Add conflict on PHPUnit ^9.6 to Drupal 9 Fixed to fix 9.5 - so that we can take our time here to get this one right.

Dropping priority back

Rerolled

I think we should try and do this before 10.1, silencing deprections or warnings and/or workarounds but at least not to remain too much behind in the release train.

In any case I think we already have issues open for most if not all the individual changes that will be needed for PHPUnit 10, and the MR in 🌱 [meta] Support PHPUnit 10 in Drupal 11 Active can be used to identify what is missing regardless of whatever we silence or skip in the meantime.

Thanks - this seems the pragmatic thing to do for now to get us on to PHPUnit 9.6, and then we fix the deprecation skips in followup issues.

Needs a rebase.

MR!3386 applies to 10.1.x for me with no issues.

OK that is weird now it's fine for me too, must be PEBKAC.

Committed fa3c3ee and pushed to 10.1.x. Thanks!

mondrake → closed merge request !3386

Could this commit be the cause of 📌 SchedulerRulesEventsTest fail with "Indirect modification of overloaded property ... has no effect" Active ? The tests were all passing 27 April, failed 8 May. D10.1 and php8.1 on both, no code changes. The only difference I can see is this PHPunit upgrade from 9.5.28 to 9.6.7

Automatically closed - issue fixed for 2 weeks with no activity.