Fix the issues reported by PHPCS

I am working on this, will provide a patch shortly

@urvashi_vora - thanks so much for doing this - just one tiny nit-pick above in comment 4...

-mike

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

Hi @ultimike,

I have made the required changes, please verify.

Thanks

Hi @apaderno,

I have updated the issue summary, Please review.

Thanks

+Issue #2782689 by yvesvanlaer, heddn, markie: How to 
+translate a custom read more link?
+Issue #2733381 by Stefdewa, Shreya Shetty: UTF-8 encoding 
+needed to show all characters correctly

It is quite hard to read the change log in that way. It would be better if the part of the line split by the previous line would be indented. I still think it would be better to leave those lines as they are, though, or change how they are formatted.

 /**
- * Class TruncateHTML.
+ * Implements Class TruncateHTML.
  */

That short description does not say what the class purpose is. (No, a class does not implement itself.)
Class is not spelled correctly, since it is not at the beginning of a sentence, it is not a proper noun nor an acronym.

Hi I just fixed the remaining errors, please revise.

-Issue #2829817 by ultimike, markie, ruloweb: Apply dependency injection (DI) to TruncateHTML class
+Issue #2829817 by ultimike, markie, ruloweb: Apply dependency
+injection (DI) to TruncateHTML class

See my previous comment. What I reported there is still valid.

HI I did a rebase and changed the changelog file according with Apaderno's comment. Please revise.

the repository needs local rebase again to fix conflicts.

I will do that

-Issue #2829817 by ultimike, markie, ruloweb: Apply dependency injection (DI) to TruncateHTML class
+Issue #2829817 by ultimike, markie, ruloweb: Apply dependency
+injection (DI) to TruncateHTML class

The splitted lines are still not indented, which means two spaces should be added to the second line.

Hi I just fixed the characters limit in the contributor.md. Please revise

Whoops.. I approved but then found this:

☁  smart_trim [smart_trim-3351447-3351447-fix-the-issues] phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig .

FILE: /Users/mark/Sites/Development/drupal10/web/modules/development/smart_trim/contributor.md
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 170 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------------------------------

Time: 658ms; Memory: 12MB

Updated the line that was at issue and merged. Thanks for your help!

+Issue #3131842 by markie, Kristen Pol, PapaGrande:
+Read more still not translated

Indenting means adding two spaces at the beginning of the line.
The second line is not indented at all, and that makes reading the list of changes done difficult to read.

Automatically closed - issue fixed for 2 weeks with no activity.