- Issue created by @jungle
- @jungle opened merge request.
- Status changed to Needs review
over 1 year ago 2:01pm 29 March 2023 - 🇨🇳China jungle Chongqing, China
@sokru: Doesn’t https://github.com/symfony/string/blob/6.2/Slugger/AsciiSlugger.php#L19-L21 mean we’d also need symfony/translation-contracts as direct dependency?
@sokru pointed out in slack symfony/translation-contracts should be added as a direct dependency as well,
- 🇬🇧United Kingdom catch
We've had trouble with translation contracts before, see #3255245: [Symfony 6] Revert 3231603 to use our own TranslatorInterface → and especially https://github.com/symfony/symfony/pull/44911, so I am not really keen on adding it back. Maybe we can fork the interface (or we might already have a fork somewhere, we went through quite a lot of different approaches at the time and I can't remember exactly where it ended up).
With symfony/string - are there other places we could potentially use it?
- 🇫🇮Finland sokru
With symfony/string - are there other places we could potentially use it?
drupal/core-transliteration component could potentially use it, but it would require quite lot of refactoring to happen.
- Status changed to Needs work
over 1 year ago 11:47am 7 April 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.