Fix the issues reported by phpcs

FILE: /Users/arunkumar/Projects/Contribution/edit_profiles_perms/tests/modules/edit_profiles_perms_test/edit_profiles_perms_test.info.yml ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/arunkumar/Projects/Contribution/edit_profiles_perms/src/EditProfilesPermsPermissions.php ----------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 25 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /Users/arunkumar/Projects/Contribution/edit_profiles_perms/src/EditProfilesPermsAccessHandler.php ------------------------------------------------------------------------------------------------------------------------ FOUND 6 ERRORS AND 1 WARNING AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------ 15 | ERROR | [x] The open comment tag must be the only content on the line 15 | ERROR | [x] Doc comment short description must be on the first line 15 | ERROR | [x] Function comment short description must start with exactly one space 15 | ERROR | [x] Doc comment short description must start with a capital letter 16 | ERROR | [ ] Doc comment short description must end with a full stop 16 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 20 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @arunkumark
Merge request !3Issue #3350990: Fix the issues reported by phpcs → (Open) created by arunkumark
Comment over 1 year ago →
🇮🇳India arunkumark Coimbatore
Created the MR to resolve the coding standard issue. Needs review and testing.
Issue was unassigned.
Status changed to Needs review over 1 year ago5:12am 29 March 2023
Comment over 1 year ago →
🇮🇳India arunkumark Coimbatore
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work over 1 year ago10:50am 29 March 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
- - edit_profiles_perms + - drupal:edit_profiles_perms
That is not the machine name of a Drupal core module.
First commit to issue fork.
Status changed to Needs review over 1 year ago12:38pm 29 March 2023
Comment over 1 year ago →
mukesh88
Status changed to RTBC 3 months ago6:56am 20 August 2024

Comment 3 months ago →

a.aaronjake

Hi @mukesh88,

Applied the changes you committed on MR!13, it was not applied smoothly but surprisingly, no errors reported and confirmed the feedback from comment #6 was addressed.

➜  edit_profiles_perms git:(1.0.x) ✗ curl https://git.drupalcode.org/project/edit_profiles_perms/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2124    0  2124    0     0   7305      0 --:--:-- --:--:-- --:--:--  7505
patching file src/EditProfilesPermsAccessHandler.php
patching file src/EditProfilesPermsPermissions.php
patching file tests/modules/edit_profiles_perms_test/edit_profiles_perms_test.info.yml
Hunk #1 succeeded at 4 with fuzz 1.
➜  edit_profiles_perms git:(1.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_profiles_perms
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Pipeline finished with Failed
3 months ago
Total: 1066s
#258901
Pipeline finished with Failed
3 months ago
Total: 1311s
#258925
Status changed to Needs review 3 months ago10:54am 20 August 2024
Comment 3 months ago →
🇮🇳India arunkumark Coimbatore
Updated the MR to support the latest 1.x-dev version of the module.
Pipeline finished with Failed
3 months ago
Total: 143s
#259142
Comment 3 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 1.0.x to hidden.
Status changed to RTBC 3 months ago6:57pm 20 August 2024
Comment 3 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
No PHP_CodeSniffer errors/warnings are reported for MR !3.
Merge request !4Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
Pipeline finished with Failed
3 months ago
Total: 139s
#259551
Pipeline finished with Failed
3 months ago
Total: 129s
#259553
Comment 3 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3350990-gitlab-ci-reports to hidden.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3Fix the issues reported by phpcs
Open

!4Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!3Fix the issues reported by phpcsOpen

!4Fix the issues reported by phpcsOpen

Comments & Activities

!3Fix the issues reported by phpcs
Open

!4Fix the issues reported by phpcs
Open