Fix @todo in \Drupal\Core\Extension\ThemeInstaller::resetSystem()

removal, but probably local tasks depends on themes enabled for Appearance menu item

Can mark this for you.

Just was about to review the related issue.

Let's see if something will fail

If local task depends on theme it should be cleaned from cache by [un]install() of theme.
But when new theme enabled there's no way for it to notify cache like "entity-list" cache tag

The last submitted patch, 5: 3350933-5.patch, failed testing. View results →

So both tests catching tabs cache!
- Drupal\Tests\system\Functional\System\ThemeTest
- Drupal\Tests\block\Functional\NonDefaultBlockAdminTest

I think this is proper place, could use to add some inline comment or `@see` when theme dependent plugins caching tasks

The last submitted patch, 9: 3350933-9.patch, failed testing. View results →

unrelated failure

Change looks good then

This needs a comment to explain why it's there.

But also, how sure are we it's needed - would be good to remove altogether and see what if anything fails + maybe manually test the appearance page with a newly installed theme if everything passes.

@catch in #5 there's 2 tests failed because of removal, its scenarios could be used for manual testing

Re-roll after 📌 Properly inject the theme registry in the ThemeInstaller Fixed

and -fail patch to get how many tests will fail

So 13 tests failed if we remove both cache tag invalidations

Sorry I missed #5. So the reason we don't clear caches is because actual rendered output varies by theme, and just adding an extra theme doesn't make existing caches invalid. We should go ahead and just clean this up as it is then in term of the code change.

The comment could be something like this:

Installing and uninstalling themes doesn't invalidate caches because rendered output varies by theme, however the tabs on the appearance page depend on the theme list, so invalidate those via the local tasks cache tag.

The last submitted patch, 15: 3350933-15.patch, failed testing. View results →

Added comment, thank you @catch

Verified todo has been added.

Committed 5187257 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.