We want to load as few as code as possible on requests, unless needed.
Currently the ThemeHandler has quite a lot of dependencies:
public function __construct($root, ConfigFactoryInterface $config_factory, ModuleHandlerInterface $module_handler, StateInterface $state, InfoParserInterface $info_parser,LoggerInterface $logger, AssetCollectionOptimizerInterface $css_collection_optimizer = NULL, ConfigInstallerInterface $config_installer = NULL, ConfigManagerInterface $config_manager = NULL, RouteBuilderInterface $route_builder = NULL, ExtensionDiscovery $extension_discovery = NULL) {
Another problem is that the module_installer exists, but the theme_handler is still responsible for installing
Move the installation code of themes into its separate entity, called ThemeInstaller.
That itself improves the performance a bit.
As BC layer we can keep ThemeHandler::install() but just call out to the other code.
Fixed
8.0 ⚰️
Last updated
It affects performance. It is often combined with the Needs profiling tag.
Enhances developer experience.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
+++ b/core/lib/Drupal/Core/Extension/ThemeInstaller.php
@@ -0,0 +1,312 @@
+ // @todo It feels wrong to have the requirement to clear the local tasks
+ // cache here.
+ Cache::invalidateTags(array('local_task'));
Filed follow-up for todo 📌 Fix @todo in \Drupal\Core\Extension\ThemeInstaller::resetSystem() Fixed