Update to CKEditor 4.23.0

Kia ora Jonathan - Patch is good, though I think the module is in dire need of a active maintainer. Especially now D7 got an extended lifetime. Let's hope someone can merge this.

TwoD → credited benjifisher → .

TwoD → credited hungdo → .

Thank you all for this. I bumped it all the way to 4.23.0 as that is an LTS and there were no breaking changes directly affecting Wysiwyg.
Expect a release soon.

Thanks! Maybe it could be added in the instructions that most users probably want the Standard (non-LTS) "Full Package" version? https://ckeditor.com/ckeditor-4/download/#ckeditor-4

It looks like the LTS-version requires a license ...

Good point. I mentioned it in the release notes but in the actual instructions would be better. I'm not able to do it this weekend but if you want to contribute a patch, open a new Docs issue.

Thanks for a fast answer and maintaining the module, I really appreciate it. I created an issue and a MR: 📌 Guide users to CKEditor non-LTS and Full Package Needs review

And thanks for the release the other day @TwoD, the module works well with the latest CKEditor 4.22.1.

Now that this has been committed, I'm marking ✨ Support CKEditor 4.18 Closed: duplicate as a duplicate.

Before we consider this closed, one concern was brought up in that issue in #5.

The 4.18 release of ckeditor has dropped the wsc spellchecker plugin.
This means that the wysiwyg will fail to load on any profile which has the Spellchecker turned on.
An admin just needs to update their wysiwyg profiles but should there be an update hook to turn that off automatically?

I didn't have the spellchecker installed, so I didn't run into the same issue. Can someone here try to replicate this and confirm whether it is/isn't an issue?

Ah, I missed that the spellecheck plugin was completely removed from the build, that does need a migration path.
Could be useful to clearly highlight the need for (and allow the input of) the license key.
Will open a new PR for this to get some input.

Looks like there is a moderate security issue https://github.com/ckeditor/ckeditor4/security/advisories/GHSA-fq6h-4g8v... so it would be good to have the module updated to support the latest LTS version. I will try to test the merge request.