[1.3.x] Single Content Sync

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Fix PHPCS issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml single_content
_sync/

FILE: single_content_sync/README.md   
----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
  9 | WARNING | Line exceeds 80 characters; contains 85 characters    
 25 | WARNING | Line exceeds 80 characters; contains 87 characters    
 28 | WARNING | Line exceeds 80 characters; contains 100 characters   
 45 | WARNING | Line exceeds 80 characters; contains 82 characters    
 58 | WARNING | Line exceeds 80 characters; contains 88 characters    
 62 | WARNING | Line exceeds 80 characters; contains 102 characters   
 67 | WARNING | Line exceeds 80 characters; contains 86 characters    
 71 | WARNING | Line exceeds 80 characters; contains 102 characters   
 78 | WARNING | Line exceeds 80 characters; contains 82 characters    
----------------------------------------------------------------------

Hi @vishal.kadam,

Did not know that phpcs is applicable for README file, this seems a bit too much, anyway, I simplified README.md file, the changes are now available in branch 1.3.x

Hi @nginex,

I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Thanks

Thank you, @vishal.kadam, I am looking forward

Hi @nginez

I've done a review of this module and I like the way it works. Most of the focus is on D10 but anyway, here is my little feedback:

• File: src/Form/ContentExportForm.php. Method handleAutoFileDownload. You don't need to use triple if statements (line 100), but just add && between conditions.
• File: src/Form/ContentExportForm.php. Method handleAutoFileDownload. Method refreshContent is missing doxy like @param, @return
• File: src/Form/ContentExportForm.php. Method handleAutoFileDownload Method submitForm. There is a switch statement with 2 cases only. I would say that a switch statement in Drupal (according to the sonarqube policies), should follow these rules: minimum 3 cases, present default case too.

  switch ($button['#name']) {
        case 'download_file':
          $file = $this->fileGenerator->generateYamlFile($entity, $extract_translations);
          break;
  
        case 'download_zip':
          $file = $this->fileGenerator->generateZipFile($entity, $extract_translations);
          break;
      }

  . I would suggest changing it to an if/else if/ or 2 if's.

• File: src/Form/ContentSyncConfigForm.php. Missing @package Drupal\single_content_sync\Form.
• File: src/ContentExporter.php. Method exportBaseValues. There is another switch statement. I would suggest adding the default option too. I saw more places with such implementation in other files.
• The core requirements says core_version_requirement: ^9.3 || ^10 but in the readme file you set example_update_8001. I would suggest changing it to 9xxx or so.
• File: single_content_sync.install. I saw some hook updates implementations. I suppose that all is configured the way you need but, what about uninstalling it? Do you remove for example this config single_content_sync.settings? I would suggest checking it. We don't need any trash after the module is uninstalled.

p.s. really love this module.

Regards,
Andrei

Hi @andrei.vesterli,

Thank you for your review, I appreciate the feedback.

I managed to fix all the feedback and pushed the changes in 1.3.x branch.

I did check what happens when users want to uninstall the module. The result is that all module related configs are removed automatically, so no extra actions needed here.

hi @nginex

really glad to know that. All i can say is “Great job”.

Nothing else from my side.

Hi @nginez,

I have reviewed the changes, and they look fine to me.
Thanks for the module, it really worked great for syncing the contents between environments.

Thanks
Siva

name: Single Content Sync
type: module
description: 'Export/import a single content between different environments.'
core_version_requirement: ^9.3 || ^10

I would increase the minimum Drupal release required, since the module is using PHP 7.4 features, and Drupal 9.3 still requires PHP 7.3. Drupal 9.4 dropped the support for PHP 7.3 → ; that is the minimum release to use for modules that expect PHP 7.4 or higher to be installed.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Hi @apaderno,

Thank you for your feedback and updating my account, much appreciated.

Concerning your feedback about php minimum version. I'm wondering, isn't enough to set "php": ">=7.4" in composer.json of the module (already there) instead of increasing minimum Drupal core version from 9.3 to 9.4?

Automatically closed - issue fixed for 2 weeks with no activity.